Git Product home page Git Product logo

Comments (12)

martinrotter avatar martinrotter commented on May 21, 2024

This problem happens when:

  1. You select some message from feed X.
  2. You update feed X and new messages arrive.

Problem is that after the update is finished, the message list gets refreshed. And if you have message sorted from newest to oldest, then your previously selected message is moved down and the same index is selected.

So if your message was for example 4th from top, 5 messages arrived, so now your message is 9th from top, but 4th message is automatically re-selected after update, but now 4th message is different.

Problem is that you can have messages sorted via various columns, RSS Guard ignores this and just selects the same 4th message because it is faster.

I could fix this so that RSS Guard will really search for your previously selected message and select it, but there are more problems. RSS Guard would have to search through all messages in current feed and search for your message, which would be slow if there tons of messages in the feed. This will become even bigger problem if there is more than one msg selected.

I agree that current behavior is buggy and needs to be fixed. Question is, how? I can just remove the reloading of messages after feed update and user would have to (re)select the feed again and all msgs would be now shown. Or I can reload the feed and just select first message. Or I can reload the feed and do not select anything.

What do you think?

from rssguard.

blackarcher21 avatar blackarcher21 commented on May 21, 2024

Honestly I prefer this way

RSS Guard would have to search through all messages in current feed and search for your message, which would be slow if there tons of messages in the feed.

But yeah, if that could slow down, that doesn't nice.

This will become even bigger problem if there is more than one msg selected.

My concern is the message that currently being displayed. I don't select more message.

Question is, how? I can just remove the reloading of messages after feed update and user would have to (re)select the feed again and all msgs would be now shown. Or I can reload the feed and just select first message. Or I can reload the feed and do not select anything.

Not sure. You might wanna check QuiteRSS. I just checked it and it keep last displayed message but don't know about performance with huge DB.

from rssguard.

martinrotter avatar martinrotter commented on May 21, 2024

I don't select more message.

Well, some other people might. What should app do if there is 5 msgs selected? Should it reselect all of them or just reselect currently visible (focused) message? I actually saw many apps which act like this, they just reselect one message and not all of them.

from rssguard.

blackarcher21 avatar blackarcher21 commented on May 21, 2024

Well, some other people might. What should app do if there is 5 msgs selected? Should it reselect all of them or just reselect currently visible (focused) message? I actually saw many apps which act like this, they just reselect one message and not all of them.

Not sure, a bit confuse with technical. My opinion as common user is reselect currently visible (focused) message since its the one that been displayed on previewer and if possible, it doesn't intefere when reading.

from rssguard.

martinrotter avatar martinrotter commented on May 21, 2024

That is true. I will fix this, so that if there is any message selected and displayed in previewer, then it will be reselected after the feed update again.

from rssguard.

martinrotter avatar martinrotter commented on May 21, 2024

Please, test ef7afcc and let me know if bug is resolved.

from rssguard.

blackarcher21 avatar blackarcher21 commented on May 21, 2024

I would test but could you upload compiled version (high compression/7z)? sorry, because I can't compile as I don't have all the requirements.

from rssguard.

martinrotter avatar martinrotter commented on May 21, 2024

http://www.filedropper.com/rssguard-333-win32

from rssguard.

blackarcher21 avatar blackarcher21 commented on May 21, 2024

looks good, now it doesn't intefere reading when feed gets updated ๐Ÿ‘
since select more than one msg doesn't open/show msg previewer, I think better it doesn't select anything doing multi-select. what do you think?

from rssguard.

martinrotter avatar martinrotter commented on May 21, 2024

Well, it is tricky. When you select multiple items, then there is still one item with focus ("current item"). Maybe it would make more sense to display "current item" in previewer even if multiple messages are selected and then when you select multiple items -> update feed -> "current" item would get correctly reselected and would be visible again.

from rssguard.

blackarcher21 avatar blackarcher21 commented on May 21, 2024

yes, thats make sense in that way.

from rssguard.

martinrotter avatar martinrotter commented on May 21, 2024

Yea, included the change in released 3.3.3 which came out today.

from rssguard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.