Git Product home page Git Product logo

Comments (22)

martinrotter avatar martinrotter commented on May 17, 2024

Is this 100% reproducible every time you try?

from rssguard.

blackarcher21 avatar blackarcher21 commented on May 17, 2024

It's not but it happens most of time.

from rssguard.

martinrotter avatar martinrotter commented on May 17, 2024

OK, it seems that there is clearly problem with mainly MySQL, I will have to use producer-consumer pattern and send all SQL queries to one single class to consume it all in one single thread to avoid these SQL transaction horrors.

from rssguard.

martinrotter avatar martinrotter commented on May 17, 2024

I try to reproduce, but cannot. So you update a lot of feeds and madly clicking on messages and it crashes?

from rssguard.

martinrotter avatar martinrotter commented on May 17, 2024

Okay, I managed it to reproduce once, will try to fix and find bug.

from rssguard.

martinrotter avatar martinrotter commented on May 17, 2024

Does this bug happen with SQLite storage?

from rssguard.

blackarcher21 avatar blackarcher21 commented on May 17, 2024

So far, it's not reproducible with SQLite. Anyway, with MySQL, it seems can be easily make it crash by mark selected items as read/unread while updating feeds.

from rssguard.

martinrotter avatar martinrotter commented on May 17, 2024

Yes yes, I managed to make it crash too. I know where the core of the problem might be. I will try to think about fix. The goal is to allow multi-thread access to DB so that user can view messages when updating feeds.

from rssguard.

martinrotter avatar martinrotter commented on May 17, 2024

I will fix this this way:

  1. All SQL operations when downloading new messages will be done in one single batch transaction. This will have two impacts:
    • When you update for example 10 feeds, all new messages from those feeds will get downloaded first and then all of them will be inserted into SQL at once. So if you update 10 feeds, you will see new messages after all feeds are updated.
    • This approach might bring another noticeable speed improvement, particularly when number of new messages will be high.
    • This approach will also lower SQL/HDD throttling.
  2. All SQL operations in separate thread (feed updating) will have unique separated database connections.

from rssguard.

martinrotter avatar martinrotter commented on May 17, 2024

This should be fixed, please test it. Use latest code from [dev] branch.

from rssguard.

blackarcher21 avatar blackarcher21 commented on May 17, 2024

could you upload please? resumable link if possible. thanks.

from rssguard.

martinrotter avatar martinrotter commented on May 17, 2024

Will upload test release for you tomorrow maybe.

from rssguard.

blackarcher21 avatar blackarcher21 commented on May 17, 2024

just updated to v3.3.4, but I can test for this because RSS Guard is not responsive when updating feeds, but feeds successfully updated. I wonder it is because DB size

here is the log file (no feeds updated in this log because they were updated on previous run)
log.txt

from rssguard.

martinrotter avatar martinrotter commented on May 17, 2024

Yea, problem is that I moved some DB updating code to main UI thread, which results in app UI thread freezing. I will move the code to feed downloader thread in 3.3.5.

from rssguard.

martinrotter avatar martinrotter commented on May 17, 2024

I made some tweak to make sure that RSS Guard main windows is more responsive during updates. You can get latest automatically compiled development release here (It will compile for 15 minutes, so wait 15 minutes from time I post this.).

Let me know if it is better.

from rssguard.

martinrotter avatar martinrotter commented on May 17, 2024

https://transfer.sh/HB4gh/rssguard-win32.7z

from rssguard.

blackarcher21 avatar blackarcher21 commented on May 17, 2024

Hi, thanks for kindly fix the issue. I'm sorry can't test and give feedback, my network connection doesn't look good so got three times timeout already, will try again later.

from rssguard.

blackarcher21 avatar blackarcher21 commented on May 17, 2024

could you upload with resumable link? I have problems when donwloading from these link. It always stop in the middle of process and I need to start again from beginning which is waste lot of my data. Sorry for asking much.

from rssguard.

martinrotter avatar martinrotter commented on May 17, 2024

Don't you have working internet connection? No, I can't I already setup this automatic build machinery, partly for you brother, since you always ask for installers.

from rssguard.

blackarcher21 avatar blackarcher21 commented on May 17, 2024

Yes, I do but not good enough stability for download. Okay, fine. Thank you. :)

from rssguard.

blackarcher21 avatar blackarcher21 commented on May 17, 2024

I can tell that this problem is fixed with newer version. Thanks.

from rssguard.

martinrotter avatar martinrotter commented on May 17, 2024

Okay, perfectos

from rssguard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.