Comments (6)
+1
from mjpopupviewcontroller.
Confirmed. Programmatically dismissing the view via dismissPopupViewControllerWithanimationType: leaves the background.
I believe the problem is the use of self in the runtime calls for associative storage.
When you create a detail view controller that you want to show as a popup, you call presentPopupViewController on the currently visible view controller, which we'll call the parent.
However, I have a dismiss button in the detail popup view that calls a method on its view controller, and it is from here that I need to dismiss the popupview. So I call dismissPopupViewControllerWithanimationType with self now as the detail view controller.
This doesn't work because the context for self has changed between presentation and dismissal from the parent view controller to the detail view controller.
Consequently, I need to get a reference back to the parent view controller and call the dismiss method on that. This is unfortunate, because now my detail view controller is coupled to the parent.
from mjpopupviewcontroller.
in case anyone still has this problem, i fixed it by replacing line 80 with this:
UIView *overlayView = [sourceView.superview viewWithTag:kMJOverlayViewTag];
from mjpopupviewcontroller.
thanks @gabreho for this fix :-)
from mjpopupviewcontroller.
Thank you for the fix @gabreho, this should be implemented into the library
from mjpopupviewcontroller.
Great work,
from mjpopupviewcontroller.
Related Issues (20)
- maskToBounds should be YES
- Using twice with different results HOT 1
- Background Blur Effect
- Can't push a view controller from controller which presented with MJPopupViewController HOT 1
- multiple view in single popup.
- World's simplest example please HOT 1
- Dismissing before view has fully appeared
- how to navigate popupviewcontroller to another viewcontroller when a button is clicked into it... HOT 2
- how to dynamic set size for PopupView HOT 9
- Keep Popup on screen HOT 2
- How to pop the view from small to big and hide from big view to small? HOT 1
- Can't push to viewcontroller in navigation controller HOT 2
- viewDidAppear and viewWillAppear are getting called twice in pop up controller.
- iOS 9 crash when closing popup
- close ban not work
- How to dismiss the UIView
- How to change color of background view?
- Can't show MJPopup on iOS 7
- How to dismiss popup with button click HOT 1
- VoiceOver
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mjpopupviewcontroller.