Git Product home page Git Product logo

Comments (6)

aleufms avatar aleufms commented on July 30, 2024

+1

from mjpopupviewcontroller.

phildow avatar phildow commented on July 30, 2024

Confirmed. Programmatically dismissing the view via dismissPopupViewControllerWithanimationType: leaves the background.

I believe the problem is the use of self in the runtime calls for associative storage.

When you create a detail view controller that you want to show as a popup, you call presentPopupViewController on the currently visible view controller, which we'll call the parent.

However, I have a dismiss button in the detail popup view that calls a method on its view controller, and it is from here that I need to dismiss the popupview. So I call dismissPopupViewControllerWithanimationType with self now as the detail view controller.

This doesn't work because the context for self has changed between presentation and dismissal from the parent view controller to the detail view controller.

Consequently, I need to get a reference back to the parent view controller and call the dismiss method on that. This is unfortunate, because now my detail view controller is coupled to the parent.

from mjpopupviewcontroller.

gabreho avatar gabreho commented on July 30, 2024

in case anyone still has this problem, i fixed it by replacing line 80 with this:
UIView *overlayView = [sourceView.superview viewWithTag:kMJOverlayViewTag];

from mjpopupviewcontroller.

tybu avatar tybu commented on July 30, 2024

thanks @gabreho for this fix :-)

from mjpopupviewcontroller.

thekevshow avatar thekevshow commented on July 30, 2024

Thank you for the fix @gabreho, this should be implemented into the library

from mjpopupviewcontroller.

rahul-apple avatar rahul-apple commented on July 30, 2024

Great work,

from mjpopupviewcontroller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.