Git Product home page Git Product logo

Comments (8)

martinhodler avatar martinhodler commented on July 28, 2024 2

@erlioniel thanks for your opinion but I closed it in the second I merged the forked repo. It is integrated with the sprite-editor version (now called Bundled in the Editor). Because I prefer to have a simple and more integrated importer without creating a lot of files and assets i will focus on the Bundled importer.

from unity-aseprite-importer.

martinhodler avatar martinhodler commented on July 28, 2024

Nice work! I didn't had the time to work on these features. In my sprite-editor branch are some of the features you were mentioning. Are you using the TextureGenerator? If yes it would be nice to set the import settings for it like unity does for images like png or jpeg.
I can add you as a contributor to be able to push changes directly to the project if this helps.
I have the same problem with my sprite-editor branch. I have to re-implement some of the features to be able to merge it on the master.

Do you have the time to integrate your solution?

from unity-aseprite-importer.

advra avatar advra commented on July 28, 2024

I tried achieving something like this earlier this year but ran into some issues with animation events accessing some of the properties which made them read-only.

I had a similar feature where you could add events to each animation; however, upon saving an ase file, the autoloader would overwrite the properties in Unity. Does this have the same issue? If so it might be better to preserve them as dynamic for read-and-write back into the ase file. Metasprite approached got around this by tagging keywords in the layer_name within aseprite.

But it seems impossible until Unity provides an interface to directly create and modify Unity Events that are attached to the animations.

from unity-aseprite-importer.

mjshin82 avatar mjshin82 commented on July 28, 2024

@martinhodler
I love to. If you make me a member of this project, then I'll integrate my code to the new feature branch.

@advra
I didn't have a overwrite issue on the animation event after re-import. But the 'Loop' property which is one of the animation property was overwritten after re-import, so I made recovery logic. And there is a similar issue in 'Custom Physics Shape' for the sprites, I also made recovery logic for that.

And there are some improvements.

  • Animator override controller support
  • Sprite Atlas support
    image
    image

from unity-aseprite-importer.

erlioniel avatar erlioniel commented on July 28, 2024

I think it is for sure worth to merge the fork somehow. I guess that the approach is more or less the same and the biggest problem is a huge diff, right?

From my perspective, it's more beneficial to merge repos or deprecate one of them. Otherwise, we will split the community (which is not huge at all)

from unity-aseprite-importer.

martinhodler avatar martinhodler commented on July 28, 2024

@erlioniel for sure.
I will merge the fork from @mjshin82 and integrate my changes afterwards. The problem for a short amount of time will be the wrong references in existing projects...

from unity-aseprite-importer.

erlioniel avatar erlioniel commented on July 28, 2024

Sure, not saying that it's easy to do. However, I'm not sure that it's a good idea to close the issue before that :)

from unity-aseprite-importer.

mjshin82 avatar mjshin82 commented on July 28, 2024

Thanks for the integration

from unity-aseprite-importer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.