Git Product home page Git Product logo

Comments (5)

missinglink avatar missinglink commented on August 21, 2024

ok, so when I downgrade to [email protected] this goes away.

from osm-read.

missinglink avatar missinglink commented on August 21, 2024

On a clean clone this also makes the test suite fail:

> mocha test/*.js


  ․․․․

  3 passing (12ms)
  1 failing

  1) when manyNodes.pbf is parsed "before all" hook:
     Uncaught TypeError: Cannot read property 'byteLength' of undefined
      at Object.blobDataToBuffer (/tmp/osm-read/lib/nodejs/buffer.js:38:34)
      at Object.inflateBlob (/tmp/osm-read/lib/nodejs/zlib.js:5:22)
      at /tmp/osm-read/lib/pbfParser.js:479:22
      at Object.readPBFElementFromBuffer (/tmp/osm-read/lib/nodejs/buffer.js:15:12)
      at /tmp/osm-read/lib/nodejs/fsReader.js:36:20
      at callback (/tmp/osm-read/node_modules/mocha/node_modules/glob/node_modules/graceful-fs/polyfills.js:207:17)
      at Object.wrapper [as oncomplete] (fs.js:454:17)

I'll see if I can find a fix

from osm-read.

marook avatar marook commented on August 21, 2024

I'm a little confused that the test suite fails on a clean clone... when I use the master branch from the repo and run npm test I get 72 passing tests?!?

I guess you have put the osm planet file somehow into the test after the clean clone?

Also I'm using mocha v1.19.0... maybe we got different versions here?

To minimize the impact of wrong library versions I've set the dependency versions in package.json to single version values. Maybe you can pull the latest changes and run the test suite again?

from osm-read.

missinglink avatar missinglink commented on August 21, 2024

Thanks, your latest commit has resolved the issue. It seems to be due to a dependency conflict and can only be reliably reproduced by killing the node_modules directory before executing npm install.

If you're interested, you can reproduce the issue on a fresh clone with node v0.10.26 by running the following commands:

git checkout ee27e7950f42514ad5f79c357647df5073013c41;
rm -rf node_modules;
npm install;
npm test;

from osm-read.

missinglink avatar missinglink commented on August 21, 2024

Check this out, pretty cool :)
http://runnable.com/U8VFY1uvsWoQaJ1A/osm-read-26-for-shell-and-bash

from osm-read.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.