Git Product home page Git Product logo

Comments (6)

slax57 avatar slax57 commented on May 17, 2024 1

Thanks for this feedback.
Until we can investigate further, note that the feature that was introduced in 1.2.0 (which likely causes the issue) can be disabled by setting enableDeepLinkRedirect to false.

from ra-auth-msal.

jonathan-marmelab avatar jonathan-marmelab commented on May 17, 2024

Hello @dicksnel,

I am the developper that implemented the deep link feature. I wasn't able to reproduce the bug on Edge (Linux), can you give me more information about your setup ?

It seems that there is an error on the Microsoft token enpoint on your logs, can you give me more information about this error as well ?

Have a nice day,
Jonathan

from ra-auth-msal.

dicksnel avatar dicksnel commented on May 17, 2024

@jonathan-marmelab I changed my implementation from:

const myMSALObj = new PublicClientApplication(msalConfig);

To:

const myMSALObj = new PublicClientApplication(msalConfig);
myMSALObj.initialize().then(() => {}});

Which seems to have fixed the issue. The demo project mentions:

[https://github.com/marmelab/ra-auth-msal/blob/main/packages/demo-react-admin/src/App.tsx

const myMSALObj = new PublicClientApplication(msalConfig);](https://github.com/marmelab/ra-auth-msal/blob/706d7f477309e50d117391b16989c3a834e49d3f/packages/demo-react-admin/src/App.tsx#L36C7-L36C7)

But this is deprecated. Newer versions of MSAL require async initialization.

Thank for the help!

from ra-auth-msal.

dicksnel avatar dicksnel commented on May 17, 2024

I made a mistake and was still running the old version. The issues is not fixed. But setting enableDeepLinkRedirect to false does work as a temporary fix.

from ra-auth-msal.

slax57 avatar slax57 commented on May 17, 2024

Thanks for the additional information.

I'll reopen the issue then.

Can you please specify what version of @azure/msal-browser shows the issue, and what version does not?

Thanks.

from ra-auth-msal.

djhi avatar djhi commented on May 17, 2024

I can't reproduce this error using our demo with MS Entra. I'm using Edge on Linux though.

from ra-auth-msal.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.