Git Product home page Git Product logo

Comments (8)

Roxy-3D avatar Roxy-3D commented on May 22, 2024

You can remove the U option (and its code) and use that for 'Unlevel Beds'.

from marlindocumentation.

ManuelMcLure avatar ManuelMcLure commented on May 22, 2024

You can remove the U option (and its code) and use that for 'Unlevel Beds'.

That works. Now to get my head around the G26 code and see how to implement this.

from marlindocumentation.

Roxy-3D avatar Roxy-3D commented on May 22, 2024

And if you feel like it... You can change the 'circles' to use the G2 Arc command instead of being simulated with 12 line segments... That should make the 'circles' draw smoother, and it also will cut out a bunch of code (and the sin() cos() tables).

from marlindocumentation.

ManuelMcLure avatar ManuelMcLure commented on May 22, 2024

I'm working on using the arc command (calling plan_arc()) and am seeing something that concerns me. It looks like plan_arc() is calling planner.buffer_line_kinematic() directly and unless I'm missing something planner.buffer_line_kinematic() does not apply any leveling unless PLANNER_LEVELING is set. PLANNER_LEVELING is defined as

#define UBL_SEGMENTED  (ENABLED(AUTO_BED_LEVELING_UBL) && (ENABLED(DELTA)))
#define ABL_PLANAR     (ENABLED(AUTO_BED_LEVELING_LINEAR) || ENABLED(AUTO_BED_LEVELING_3POINT))
#define ABL_GRID       (ENABLED(AUTO_BED_LEVELING_LINEAR) || ENABLED(AUTO_BED_LEVELING_BILINEAR))
#define OLDSCHOOL_ABL  (ABL_PLANAR || ABL_GRID)
...
#define PLANNER_LEVELING      (OLDSCHOOL_ABL || ENABLED(MESH_BED_LEVELING) || UBL_SEGMENTED || ENABLED(SKEW_CORRECTION))

so as far as I can tell PLANNER_LEVELING is not set if using UBL on a cartesian printer and therefore it looks like leveling is not applied to arc moves. If I'm missing something please let me know.

from marlindocumentation.

Roxy-3D avatar Roxy-3D commented on May 22, 2024

Yikes! I think you are correct. It might be we should have a #if ENABLED() for the UBL non-segmented case to send it down the correct path.

THANK YOU for finding this!

from marlindocumentation.

ManuelMcLure avatar ManuelMcLure commented on May 22, 2024

Do you want me to enter an issue for this? I'm somewhat leery of attempting to fix this myself since I'm just learning the code and I'm not sure exactly what the interactions are involved between different levels and at what level the fix needs to be in.

from marlindocumentation.

ManuelMcLure avatar ManuelMcLure commented on May 22, 2024

It looks like bezier curves have the same issue.

from marlindocumentation.

Roxy-3D avatar Roxy-3D commented on May 22, 2024

Yes, please open an issue. (But in the Marlin/Firmware area... Otherwise it might not get the attention that it needs.)

from marlindocumentation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.