Git Product home page Git Product logo

Comments (6)

marlimox avatar marlimox commented on June 16, 2024 2

Hi @ParkGwangBeom, I’m so sorry for the slow review of this last PR - I have only had access via my phone for the past week, no computer unfortunately. I’ll review this ASAP. Thank you for your patience!

from aloestackview.

ParkGwangBeom avatar ParkGwangBeom commented on June 16, 2024 1

Hi. If you have time, please take a look at PR (#12 )! Thank you!

from aloestackview.

marlimox avatar marlimox commented on June 16, 2024

I like this idea, great suggestion!

I’d want to balance this with making sure the library doesn’t become too complicated though.

If you could provide some concrete examples of use cases where this would be very valuable, I think that would help.

If it’s just for one particular use case that doesn’t happen very often, then it might be better to extend AloeStackView and add this behavior as a customization.

For example, one way might be to override the addRow etc. methods in a subclass of AloeStackView and have them call your own custom protocol method on the row if animated is true.

The idea with AloeStackView is to keep the core very small and simple, but provide extensive support for customization. That way many things can be achieved with it, but the core library won’t become too big or complicated by having lots of features that only address niche use cases.

I’m not sure where this feature fits on that scale yet, so some concrete examples would help!

Thanks again for the great suggestion 😄

from aloestackview.

ParkGwangBeom avatar ParkGwangBeom commented on June 16, 2024

What I think is that the contentView of the StackViewCell will each be able to handle animation related. (Animatable (?) Protocol such as Highlightable, Tappable, etc.)

For example, when a view is addRow, you will have its own effect of whether the imageView inside the contentView is flashing or not.

I think AloeStackView's own code will not get complicated.
I will give you PR after simple implementation :)

tell me your opinions!
Thanks you.

from aloestackview.

marlimox avatar marlimox commented on June 16, 2024

Sounds good. Please feel free to put up a PR demonstrating your ideas and approach!

from aloestackview.

ladislas avatar ladislas commented on June 16, 2024

any news on this? :)

from aloestackview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.