Pretty indendation and coloring should be separate options about cq HOT 8 CLOSED

Thanks for the suggestion!

I think let's start with --color=off --color=auto (default) --color=on

with shorthands -c for on and -C for off

off = puget/pprint
on = puget/cprint
auto = on (later we can add tty detection)

happy for a PR on this @Macroz

from cq.

So maybe don't force puget/cprint here but use ppt/pprint or puget/pprint? https://github.com/markus-wa/cq/blob/main/src/cq/formats.clj#L42

Since this repo is in Hacktoberfest I could be interested in doing a PR on this.

from cq.

implemented in the latest release - thanks @Macroz https://github.com/markus-wa/cq/releases/tag/2022.10.12-14.51.05

from cq.

pretty was released with automatic logic for enabling colors. Seems pretty straightforward: clj-commons/pretty@7cb0c16

from cq.

Thanks @hukka - I've created #18 to support this.

PRs welcome as I probably won't get to this for a while

from cq.

So I implemented #18 as described, but I'm not sure this logic (from pretty) works as desired.

The code detects if you are in a TTY alright, but if you don't pipe to a file but to your terminal (e.g., for one-off manual use and exploration), you probably want to see the colors. You are likely also not in a REPL. So this kind of detection would mean the default is uncolored, and you must force the colors with a flag pretty much always.

Any more ideas?

from cq.

Thanks @Macroz - I think that's as good as it gets.

As far as I'm aware there is no way to differentiate between pipe to command vs pipe to file (also, commands like tee may write to both a file and to TTY).

It's preferrable to break colouring vs breaking pipe to file.

Would you be able to open a PR? 😄

from cq.

Right!

How about this for a PR #20?

from cq.