`path.join` mangles schema-delimiting double-slash about gatsby-plugin-feed-generator HOT 8 CLOSED

I just tried this plugin and I think I ran into this bug. My siteUrl is "https://anti-pattern.com" but the URL is mangled in two places (that I can see).

In the JSON feed the feed_url is "https:/anti-pattern.com/feed.json/.json".

In the XML feed the image.url is "https:/anti-pattern.com/image.png".

from gatsby-plugin-feed-generator.

@brandonweiss Any chance you could provide the config that is causing this?

from gatsby-plugin-feed-generator.

@markmichon Of course!

siteMetadata: {
  author: "Brandon Weiss",
  description: "description",
  title: "Anti-pattern",
  siteUrl: "https://anti-pattern.com",
},
plugins: [
  {
    resolve: "gatsby-plugin-feed-generator",
    options: {
      rss: true,
      json: true,
      siteQuery: `
        {
          site {
            siteMetadata {
              author
              description
              title
              siteUrl
            }
          }
        }
      `,
      feeds: [
        {
          name: "feed",
          query: `
          {
            allMdx(sort: { fields: [frontmatter___date], order: DESC }) {
              edges {
                node {
                  html
                  fields {
                    slug
                  }
                  frontmatter {
                    date
                    title
                    description
                  }
                }
              }
            }
          }
        `,
          normalize: ({ query: { site, allMdx } }) => {
            return allMdx.edges.map(({ node: post }) => {
              return {
                date: post.frontmatter.date,
                html: post.html,
                title: post.frontmatter.title,
                url: site.siteMetadata.siteUrl + post.fields.slug,
              }
            })
          },
        },
      ],
    },
  },
],

I didn’t think to include it because it seemed like a standard/default config, but maybe there’s something unusual I’m doing.

from gatsby-plugin-feed-generator.

@brandonweiss Thanks! Yeah nothing looks out of the ordinary there.

Should be resolved now. Let me know if you run into any issues. I couldn't duplicate it, but I suspect it had to do with trailing slashes. 2.0.1 handles that issue.

from gatsby-plugin-feed-generator.

@markmichon Thanks! The backslash issue seems to be fixed, although the extension on feed_url still seems to be doubled. It’s showing as "https://anti-pattern.com/feed.json.json".

from gatsby-plugin-feed-generator.

Ah yeah, the extension is being added in two places.

I’d normally open a PR but I’m not sure exactly where you’d prefer to do the appending.

from gatsby-plugin-feed-generator.

Alright. Latest release on npm has it taken care of. Thanks for keeping things in check 👍

from gatsby-plugin-feed-generator.

Thanks for fixing it so quickly! ❤️

from gatsby-plugin-feed-generator.