Comments (2)
Hi!
I'm flattered you think about me for an advanced question :).
I think it's fine. About the dot, as far as I know :
- dots in the middle of the name are often discouraged because there is an ambiguity with S3 methods but it doesn't apply to your case
- I think these can however fire the autocomplete in your ide, but i don't think it will impact the experience that much
- dots at the start of the name will make your variable not listed by ls (by default), so should not be done without a good reason, parameter names are ok.
- two dots at the start of the name should be be avoided because (I think, maybe I'm wrong) they're sometimes used when you need a variable in your environment but make sure they don't mask a realistic variable name, so better stay off those to avoid weird issues.
The other issue is that .
doesn't say anything other than "it's a variant", so when you see select_
, select
and select.
it can be confusing, but on the other hand it makes things readable so I think it's a reasonable choice.
Do you know about tidyfast ? I never really used it much but it seems to do the same kind of things as your package, and had the same function names before you changed yours.
For this kind of issues i'd typically tweet, but pinging we on github is fine too.
Good luck in any case. It seems like people like it a lot already!
from tidytable.
Thanks for the response, I really appreciate it. Those points all make sense. I think I'll move forward with the verb.()
syntax.
As for tidyfast - I contributed dt_pivot_wider()
& dt_pivot_longer()
to tidyfast a while back when both of our packages used the dt_
prefix . (Since that time I switched my package to using an rlang
backend and ended up remaking both functions for my package as well.)
One of the reasons I wanted to switch to verb.()
was because a few packages seem to have adopted the dt_
style (like maditr and tidyfast), and I wanted to figure out a way to have a different syntax that was still recognizable to tidyverse users.
Thanks again for your help!
from tidytable.
Related Issues (20)
- Can't use "unique" or "sorted" as names in `expand_grid()`
- `compat-zeallot.R` to `standalone-zeallot.R`
- Auto-name inputs to `tidytable()` to match `tibble()`
- Add `by` to `slice_*()` family
- vctrs 0.5.3: Replace `vec_assert()` usage
- Use of tidytable functions before `dplyr::collect()` HOT 6
- Remove on load message about dotless functions
- Use `rlang::call_args()` where possible
- Update internal `check_across` HOT 4
- `count()` gives error for code that works in `dplyr::count()` HOT 1
- Fix CRAN check issue
- Release v0.10.0
- Pass a pre-made list of functions to `across()` HOT 3
- Allow integration with `dbplyr` HOT 5
- vctrs v0.6.0
- case_when not working properly when one condition includes NAs HOT 3
- Update readme to use `pak::pkg_install()`
- Remove `rlang::squash()` usage
- Implement `reframe()`
- `pivot_wider` returning NA when names_from is a date HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tidytable.