Comments (4)
It kind of makes sense to offer a complete dark experience (I would personnaly love it), but either I encountered a bug in the display either I suggest you rework the colors for dark mode because the current display is really hard to read
That looks like a bug. Can you tell me which dark theme / extension you are using?
By the way, now that I think about it, I'm wondering if that would be possible to automatically retrieve the NextCloud theme color, and possibly the accessibility theme, to apply it to the Passwords extension.
That does make sense, and the app actually supports this with the new api. But this extension is older than the app and still uses the legacy api, so it can't access the info.
As soon as i have time to rewrite the extension, i will also make sure to include proper theming support.
from passwords-webextension.
Version 1.7.0 has been released and offers a dark mode which fixes the issue.
from passwords-webextension.
Hello Marius,
Indeed, the release 1.7.0 offers a dark mode which will switch the icon to something visible even when using a dark Chrome theme... but I was not expecting the Passwords screen to also turn to the dark(ish) side.
It kind of makes sense to offer a complete dark experience (I would personnaly love it), but either I encountered a bug in the display either I suggest you rework the colors for dark mode because the current display is really hard to read:
Usually, dark modes tend to switch background-color to a blackish color (not a full black though, more like #222222
or #333333
) and the color to a light gray (something like #c0c0c0
or #a0a0a0
) which makes it easy on the eye and easy to read.
You might want to checkout NextCloud 14 dark mode to try to offer a consistent display: https://www.youtube.com/watch?v=S_842AQx3MQ
By the way, now that I think about it, I'm wondering if that would be possible to automatically retrieve the NextCloud theme color, and possibly the accessibility theme, to apply it to the Passwords extension.
Does it make sense ?
If it does, I might create a new issue to track the request.
Anyway, thank you much for your amazing work.
from passwords-webextension.
I am using Chrome "Dark Theme v3" of Marco De la Cruz:
https://chrome.google.com/webstore/detail/dark-theme-v3/djlgdeklopcjagknhlchbdjekgpgenad
Just to make sure, I reverted the theme to Chrome default, restarted browser, and still see the same display in dark mode.
For information I am using Google Chrome Version 71.0.3578.98 (Build official) (64 bits)
Would you like me to open a separate issue or do you wish to keep tracking it here ?
from passwords-webextension.
Related Issues (20)
- Can't install the extension on Brave browser HOT 4
- Support a blacklist for sites to not track passwords for HOT 1
- First connection to Nextcloud instance HOT 2
- "No Elements Found" HOT 6
- Firefox: Error with loading data when initially the Internet connection was missing HOT 1
- no match when more than 3 URLs linked to entry HOT 1
- Feature Request: Optional Pin/Biometric Lock after initial password sign-in HOT 3
- 2.4.0 Not working with Vivaldi HOT 3
- Automatically paste active tabs' credentials upon unlocking HOT 1
- Warning about needing a new version that hasn't been released yet HOT 1
- Search not working HOT 19
- Blocking issue after new installation - Expected application/json, got text/html HOT 2
- A lot of sessions open by the extension in Nextcloud HOT 1
- [BUG]: Extension is locking my account on Active Directory
- [BUG]: Extension shows "no elements" after upgrading to NC 28
- [FEATURE]: Save/Trash buttons in new password tab
- [BUG]: Could not open database error HOT 5
- [FEATURE]: Share password directly from Webextension
- [FEATURE]: Longer Auto-Lock timeout
- [BUG]: must log in twice daily; auto-logged out right after first login HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from passwords-webextension.