Git Product home page Git Product logo

Comments (5)

marcuswestin avatar marcuswestin commented on May 21, 2024

Hey alystair,

That would be a great! I'd definitely pull a patch.

Thanks for the suggestions.

from store.js.

alystair avatar alystair commented on May 21, 2024

Actually I was hoping that you could add the commenting (since you originally created the script and know exactly what browser does what [hopefully]), so I could focus on index/length/push/pop :)

from store.js.

marcuswestin avatar marcuswestin commented on May 21, 2024

Ah, I see. Well, the implementation is based on feature detection and I don't believe comments of which browser supports what method is necessary. For example, I don't see how implementation of a feature like index/length/push/pop would depend on which browser it is in if you can assume that the underlying get/set api works.

If there is a web page with a table of support out there than linking to that in the readme could definitely be useful. I would very much appreciate if you took the time to find or make one!

Cheers,
Marcus

from store.js.

marcuswestin avatar marcuswestin commented on May 21, 2024

Considering the implementation is feature detection based rather than browser detection, I don't think this is a relevant issue. Closing. Feel free to reopen with additional info/comments if you think it's importan.t

from store.js.

marcuswestin avatar marcuswestin commented on May 21, 2024

.

from store.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.