Git Product home page Git Product logo

Comments (4)

marcuswestin avatar marcuswestin commented on May 22, 2024

Hey jdunck,

Thanks for the request!

Would (store.get(key, defaultValue)) act differently from (store.get(key) || defaultValue)? If not, I think it's to the advantage of a user of store.js to add a parameter to the .get signature.

Cheers!

from store.js.

jdunck avatar jdunck commented on May 22, 2024

Well, store.get(...) || default would use default if the get return is false-y. To be equivalent, it would need to be:
store.get(...) == undefined || default.
I'm just trying make use a bit more concise, but it's a small matter.

from store.js.

marcuswestin avatar marcuswestin commented on May 22, 2024

Since local storage coerces values into string store.set('foo', false); store.get('foo') == 'false'.

Thanks for the suggestion, but I think keeping a clean and straight-forward small implementation that's easily modified will serve everyone well.

Closing the issue for now - feel free to reopen if you believe there are strong reasons to implement the feature.

Thanks!

from store.js.

jdunck avatar jdunck commented on May 22, 2024

Well, my other commit serializes to JSON if available. I need that one, this one is just nice. :-)

from store.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.