Map conversions about ditiow HOT 13 CLOSED

I am a first time contributor, and I would like to contribute to this. How can I get started?

from ditiow.

Also, is this supposed to be Address or Point as the type parameter?

Address is the business entity so you need to inform Address as type. Is it right @ahmadmoawad ?

from ditiow.

Hi @akshitproothi

we don't have a map conversion so if a map has a Resource as a value Ditiow will not detect it.
This feature is very similar to the collection conversion. You can take a look at assemblyMap method.

Tks

from ditiow.

Ok thanks @marcosvidolin . Is there any setup guide i could follow to run and test this on my machine?

from ditiow.

Hi @akshitproothi you can check the setup guide at README and run ./gradew test to execute all tests from terminal

from ditiow.

Ok, thanks. Taking a look.

from ditiow.

@marcosvidolin Do you also want me to update the getFieldGenericType method?

I am unable to test my changes unless this method handles the value type of a map.

from ditiow.

Also, is this supposed to be Address or Point as the type parameter?

from ditiow.

@marcosvidolin Do you also want me to update the getFieldGenericType method?

I am unable to test my changes unless this method handles the value type of a map.

Yeah, please.

from ditiow.

One more thing @marcosvidolin @ahmadmoawad : In this code , I noticed that the AddressResource is there but the list of points is not a List of PointResource but a List of Point . Shouldn't the UserGetResource only include subtypes of AbstractResource? The code here used for the ResourceAssemblerTest doesn't populate that list either so it skips the test for that field (which would fail here because of type mismatch)

from ditiow.

Created a PR for the map conversion. Please let me know about the above questions i asked, and if you need me to make any changes related to those.

from ditiow.

One more thing @marcosvidolin @ahmadmoawad : In this code , I noticed that the AddressResource is there but the list of points is not a List of PointResource but a List of Point . Shouldn't the UserGetResource only include subtypes of AbstractResource? The code here used for the ResourceAssemblerTest doesn't populate that list either so it skips the test for that field (which would fail here because of type mismatch)

Yes, you are right! It should be an AbstractResource.

from ditiow.

Created a PR for the map conversion. Please let me know about the above questions i asked, and if you need me to make any changes related to those.

Thank you @akshitproothi for the improvements.
I'll review and merge it. 😎

from ditiow.