Git Product home page Git Product logo

Comments (5)

marcoroth avatar marcoroth commented on June 12, 2024 1

@kg-currenxie yeah that's somewhat related, this is like the combination of #63 and #64 🙃

from stimulus-parser.

marcoroth avatar marcoroth commented on June 12, 2024

Hey @MSchmidt, yeah, I think there are some cases were Stimulus LSP doesn't properly detect a controller imported via Importmaps, specficially if you import controllers from URLs? Is this also the case in your example?

Otherwise, would you mind showing your config/importmap.rb? Thank you!

from stimulus-parser.

MSchmidt avatar MSchmidt commented on June 12, 2024

I'm storing everything locally. Installed with
bin/importmap pin stimulus-reveal-controller --download

The issue is specifically with stimulus-scroll-reveal in this case.

# config/importmap.rb
pin "application", preload: true
pin "@hotwired/turbo-rails", to: "turbo.min.js", preload: true
pin "@hotwired/stimulus", to: "@hotwired--stimulus.js" # @3.2.2
pin "@hotwired/stimulus-loading", to: "stimulus-loading.js", preload: true
pin_all_from "app/javascript/controllers", under: "controllers"
pin "stimulus-dropdown" # @2.1.0
pin "hotkeys-js" # @3.12.0
pin "stimulus-use" # @0.51.3
pin "stimulus-scroll-reveal" # @3.2.0

from stimulus-parser.

marcoroth avatar marcoroth commented on June 12, 2024

Ah, I see. Thanks for the context @MSchmidt!

This is probably a duplicate of #64 in that case then.

from stimulus-parser.

kg-currenxie avatar kg-currenxie commented on June 12, 2024

I have a case like this

import Dropdown from 'stimulus-dropdown'

export default class extends Dropdown {
  toggle(event) {
    // custom code here
    super.toggle()
  }

  hide(event) {
    // custom code here
    super.hide(event)
  }
}

image

is this related? or should we track it in a new issue?

from stimulus-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.