Git Product home page Git Product logo

Comments (2)

MarcinMoskala avatar MarcinMoskala commented on May 30, 2024

This code looks good, but I am not sure why placing it inside PreferenceHolder? It could be placed in any other class as long as the same SheredPreferences are used. Maybe instead I should just add an option to register concrete SheredPreferences instead of passing Context? Then you could initialize both in Application:

val preferences = PreferenceManager.getDefaultSharedPreferences(context)
PreferenceHolder.setPreferences(preferences)
PreferenceListeners.setPreferences(preferences)

This solution would be more general.

from preferenceholder.

sugarmanz avatar sugarmanz commented on May 30, 2024

Yeah. That makes a bit more sense. The only reason I would consider including it in this library is it would remove boilerplate code for each app I want to use preference listeners in conjunction with preferenceholder.

from preferenceholder.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.