Comments (13)
sanketjo96
commented on May 26, 2024
Hey Marc - did you get chance to go over this ?
from react-virtualized-sticky-tree.
marchaos
commented on May 26, 2024
Hey. Not yet sorry. I'm back at work on Monday so should have some time
then
…On Fri, 27 Dec 2019, 08:32 sanketjo96, ***@***.***> wrote:
Hey Marc - did you get chance to go over this ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#15?email_source=notifications&email_token=AAVBY6LM3KUA2W6DKUA3IR3Q2W4RPA5CNFSM4J6WWIR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHWZ5WY#issuecomment-569220827>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVBY6IF5RLZLUUAHXVH7ETQ2W4RPANCNFSM4J6WWIRQ>
.
from react-virtualized-sticky-tree.
sanketjo96
commented on May 26, 2024
Did you get a chance to have a look marc ?
from react-virtualized-sticky-tree.
marchaos
commented on May 26, 2024
Hey @sanketjo96. Thanks for the sandbox - I can see that node 8 is actually removed from the dom, so should be easy find out what's going on.
from react-virtualized-sticky-tree.
sanketjo96
commented on May 26, 2024
Thanks for reply. Could you please let me know if/when you are planning on fix ?
from react-virtualized-sticky-tree.
marchaos
commented on May 26, 2024
Hey @sanketjo96. I haved fixed this in branch issue_15. Just sorting out a release.
from react-virtualized-sticky-tree.
marchaos
commented on May 26, 2024
I've pushed a new version. Can you try 2.1.26 ? https://codesandbox.io/s/xenodochial-wu-feq0t?from-embed
from react-virtualized-sticky-tree.
sanketjo96
commented on May 26, 2024
Thanks Marc for fix. Wll try out with new version and will notify here. Thanks a lot again
from react-virtualized-sticky-tree.
sanketjo96
commented on May 26, 2024
Hey Marc, I am done with initial round of testing and found a bit different issue. I am unable to scroll back up using scrollNodeIntoView
Please have a look at - Sandbox
- Click on "Jump to child 3" it works fine
- Click on "jump to child 3" again. Everything looks good and original reported issue is no longer present
- Now click on "jump to child1" > Unable to jump on Child 1.
This worked well when I synced lib back to 2.1.25
Can you please have a look ? I guess we are always returning early when we reach to max scroll position. May be we need to consider the case when user wanted to scroll back up.
from react-virtualized-sticky-tree.
marchaos
commented on May 26, 2024
Hey. Yes, will take a look. If you can, I'll get a branch for you to test before releasing.
from react-virtualized-sticky-tree.
sanketjo96
commented on May 26, 2024
Yes. That will make it safe. Thanks for quick response.
from react-virtualized-sticky-tree.
sanketjo96
commented on May 26, 2024
Hey - Please share the branch once you commit the change. Thanks.
from react-virtualized-sticky-tree.
marchaos
commented on May 26, 2024
See comments in other issue - looks to be border related.
from react-virtualized-sticky-tree.
Related Issues (20)
- Always getting SCROLL_REASON.OBSERVED even after setting through setScrollTop HOT 7
- Question: Would this lib support unknown cell height? HOT 1
- Update component lifecycle methods HOT 3
- The last node from list does not render in DOM HOT 5
- Code for react-virtualized-sticky-tree demo HOT 2
- Any plans of moving to hooks? HOT 5
- DOM not utilising entire window Height: Video HOT 3
- Cannot read property 'top' of undefined HOT 2
- Quick scroll missing render HOT 1
- List Missing HOT 1
- Custom renderer for parent-node and list-node HOT 2
- prop scrollTop is not working? onScroll event cause a bug. Gif proof HOT 4
- ForceUpdate HOT 1
- transformY rather than top HOT 1
- Flex-direction column-reverse
- Cannot read properties of undefined (reading 'id') HOT 4
- Is there a link to the source for the demo? HOT 1
- Keyboard navigation gets stuck after scrolling for a little bit HOT 5
- Sample code doesn't seem to work HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-virtualized-sticky-tree.