Strange behavior when reusing connection about bojack HOT 10 CLOSED

Have you tried to disable Nagle algorithm by setting tcp_nodelay to true?
https://crystal-lang.org/api/0.18.7/TCPSocket.html#tcp_nodelay%3F-instance-method

from bojack.

Other programming languages have this very same problem due to how Nagle works. If it works, we should think about it. Here is a nice reading about the topic: https://www.extrahop.com/community/blog/2009/to-nagle-or-not-to-nagle-that-is-the-question/

from bojack.

My results:

➜  bojack git:(master) ✗ crystal run --release benchmarks/socket_nagle.cr 
             user     system      total        real
shared   0.000000   0.000000   0.000000 (  0.007952)
new      0.000000   0.010000   0.010000 (  0.015957)

from bojack.

@mauricioabreu / @hugoabonizio I was doing the same thing last night, but I was trying to measure how long it would take to have like 100_000 or 1_000_000 keys in the database. The thing is we have some consistency/concurrency issues on handling several requests.

I had to test this with ruby, because I wasn't able to create many parallel tcp requests with Crystal for some reason.

Take a look at the benchmarks branch.

from bojack.

Interesting! I didn't know about Nagle's algorithm yet. Disabling for both client and server the performance was much better. It seems like Redis disables this by default, should we do the same?

from bojack.

@hugoabonizio I don't know. I suck at TCP but it is worth a try. :)

@marceloboeira what is this "consistency/concurrency" problem exactly?

from bojack.

@hugoabonizio gonna have a look on this, but if it increases performance and redis is doing it, probably we should!

from bojack.

@mauricioabreu it seems that we are not correctly implementing the "secure" routine for the TCP connection/request handler.

Please read #19 for a complete answer!

from bojack.

@hugoabonizio will you handle the Nagle's thing? cause I would like to try solving the concurrency problems yet it will take me a while.

from bojack.

@marceloboeira OK!

from bojack.