Git Product home page Git Product logo

Comments (2)

marcelm avatar marcelm commented on August 28, 2024

I support this! I haven’t seen R3 files, yet, but there’s been requests for demultiplexing support in Cutadapt by using I1 files. An are_mates function would be a good step towards support for reading three input files. The only alternative name I can up with at the moment is is_trio, but that evokes the wrong connotation. I think are_mates is fine. (Edit: Or is_triple)

from dnaio.

rhpvorderman avatar rhpvorderman commented on August 28, 2024

I think we should implement as follows:

def are_mates(self, *args) where args is a tuple of SequenceRecord objects. Since we cannot do three-way comparison of memory in C anyway, we need to compare two times. This can be done in a simple loop where self is compared to any number of sequence records in args. That way we are immediately future proofed against any number of comparisons, and the name are_mates nicely reflects that.

The advantage here is that we only have to do the costly strcspn function once per comparison.

from dnaio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.