Sigsegv when pressing a fan control button, card HD6870 on r600 about radeon-profile HOT 11 CLOSED

Yes, the bug definitely is where @Danysan1 pointed out, wrong tab being disabled when no fan control available. Fixed here 47fc81b

from radeon-profile.

This should fix it: Danysan1@1c1e051
(I say 'should' because i can't test it since I'm currently using a spare fanless card)

from radeon-profile.

Thanks for the quick answer, unfortunately it doesn't fix the segfault.

The more exact backtrace for clicking Custom curve is

0 QList<QAction*>::QList (l=..., this=0x7fffffffd300, this@entry=0x7fffffffd2a0) at ../../../qt-everywhere-opensource-src-4.8.6/src/corelib/tools/qlist.h:122
1 QWidget::actions (this=0x7fffffffe558) at /usr/src/debug/dev-qt/qtgui-4.8.6-r4/qt-everywhere-opensource-src-4.8.6/src/gui/kernel/qwidget.cpp:3344
2 0x000000000048699b in radeon_profile::findCurrentFanProfileMenuIndex (this=this@entry=0x7fffffffe2a0) at uiEvents.cpp:505
3 0x0000000000486cd9 in radeon_profile::setCurrentFanProfile (this=this@entry=0x7fffffffe2a0, profileName=..., profile=...) at uiEvents.cpp:541
4 0x0000000000486ea9 in radeon_profile::on_btn_pwmProfile_clicked (this=0x7fffffffe2a0) at uiEvents.cpp:84

Specifically, in radeon_profile::findCurrentFanProfileMenuIndex the
*fanProfilesMenu->actions().count() function call segfaults.

When clicking Fixed the backtrace is

0 QList<QAction*>::QList (l=..., this=0x7fffffffd3b0, this@entry=0x7fffffffd3a0) at ../../../qt-everywhere-opensource-src-4.8.6/src/corelib/tools/qlist.h:122
1 QWidget::actions (this=0x7fffffffe558) at /usr/src/debug/dev-qt/qtgui-4.8.6-r4/qt-everywhere-opensource-src-4.8.6/src/gui/kernel/qwidget.cpp:3344
2 0x0000000000486bd0 in radeon_profile::on_btn_pwmFixed_clicked (this=0x7fffffffe2a0) at uiEvents.cpp:63

and it is fanProfilesMenu->actions()[1]->setChecked(true); the results in the segfault.

Now splitting of that line into

auto act = anProfilesMenu->actions()
act[1]->setChecked(true); 

shows that the first line, i.e. copying the actions in the Qlist copy constructor results in the failure, which means that these actions are probably not initialized in a way they should be.

Maybe this is related to the fact that the overclocking tab and/or the profiles tab on the GPU Summary screen are disabled.

from radeon-profile.

Your last suggestion may actually be the real problem: basing on what I read here ( #17 (comment) ) your card should not support fan control, so your fan tab should be grayed out.

And in fact the setupUiEnabledFeatures() function does wrongly gray out the tab 2 (overclock) instead of the tab 3 (fan control): Danysan1@9d13bda#diff-cda7bc0581cc82ab9f765694a7a02bc6L204
Could you try this commit?

from radeon-profile.

@gerddie
Does the application display fan speed? I don't think that R600 has fan control support so the bug might be that fan control tab isn't disabled and you have access to those buttons.

Maybe this is related to the fact that the overclocking tab and/or the profiles tab on the GPU Summary screen are disabled.

Profile tab and DPM are mutually exclusive so nothing wrong here if you use DPM.

from radeon-profile.

@marazmista: Yes, it may be that the driver doesn't support it, the card definitely does, since with the frglx driver and aticontrol I can set the speed.

from radeon-profile.

@Danysan1 Okay, with the patch overclock and fanspeed are disabled

from radeon-profile.

You can check if you have files named pwm* in /sys/class/drm/cardX/device/hwmon/hwmonX/. If not, there is no support.

from radeon-profile.

Yes, no fan support in r600l. I've also looked at the r600_dpm.c kernel code, and (unlike with si_dpm.c) there is no code for fan control, and the radeon_asic.c there are also no functions assigned to the fan control interface.

from radeon-profile.

This last commit properly grays out fanspeed. overclock is also disabled, but I guess that this is also to be expected because the file /sys/class/drm/card0/device/pp_sclk_od does not exist on my system.
Closing this issue.

from radeon-profile.

Upstream bug for fan control in R600.

from radeon-profile.