Git Product home page Git Product logo

Comments (3)

amk221 avatar amk221 commented on August 23, 2024

Seconded. There are various abstractions that don't seem to be implemented. I've had to write the following functions to fill in the gaps. This is the sort of thing Mapstraction should be preventing.

map.click.addHandler(function() {
    // Close all bubbles when the map is clicked
});

map.markerRemoved.addHandler(function( name, src, args ) {
    // Close this marker's bubble when it is removed from the map
});

map.markerAdded.addHandler(function( name, src, args ) {

    args.marker.click.addHandler(function( name, marker ) {
        // Open this marker's bubble when it is clicked
    });

    args.marker.openInfoBubble.addHandler(function( name, marker ) {
        // Close all bubbles except this one, when a marker is clicked
    });

});

from mxn.

vicchi avatar vicchi commented on August 23, 2024

Agreed. Do you have an implementation you can share? Otherwise, I'll look at getting this done, hopefully in time for the next release.

from mxn.

gilesc50 avatar gilesc50 commented on August 23, 2024

This is already in place on the release 3 branch:

Mapstraction.prototype.removeMarker = function(marker) {    
var current_marker;
for(var i = 0; i < this.markers.length; i++){
    current_marker = this.markers[i];
    if(marker == current_marker) {
        marker.closeBubble();
        this.invoker.go('removeMarker', arguments);
        marker.onmap = false;
        this.markers.splice(i, 1);
        this.markerRemoved.fire({'marker': marker});
        break;
    }
}
};

So am closing this issue

from mxn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.