Comments (4)
When using a numbered tag higher than 15, PBF will throw errors. Tags starting at 16 should be used to encode less frequently used fields, as the tag takes up two bytes instead of one.
Are you able to provide a simple proto file that reproduces this bug? There's only one unit test for this case.
pbf/test/fixtures/packed_proto3.proto
Lines 20 to 22 in bc2da8f
Lines 74 to 90 in bc2da8f
I tried a few simple combinations and was unable to break it.
Update
When using more than 127 repeatable elements, PBF will throw errors like "Uncaught Error: Unimplemented type: 7" or it will parse the fields incorrectly, seemingly at random, even with the exact same input.
I was also unable to cause this issue. A protofile that reproduces would be appreciated. Thanks!
from pbf.
@Ziao Are you able to provide proto files that reproduce?
from pbf.
Sorry for the late reply. I'll upload an example proto file and schema asap.
from pbf.
Closing this issue because of a lack of reproducible test cases. Will happily reopen once those are provided and verified.
from pbf.
Related Issues (20)
- osm-file processing HOT 1
- Implementing the depreciated start and end groups types HOT 1
- Generate typescript declarations HOT 2
- ENOENT error for valid proto files HOT 2
- Empty string decoded as true as map value HOT 1
- Error using google.protobuf.Any HOT 9
- Performance question HOT 1
- strange coordinates after parser mapbox pbf HOT 1
- Converting pbf to typescript - Both the compiler and the output. HOT 2
- Handling of nulls in writePackedVarint HOT 2
- I use nodejs request module, can not create a Pbf object HOT 1
- pbf is rounding Long Integer values to nearest value why ?
- pbf is rounding the Long integer value to nearest value why? HOT 2
- ESM Support HOT 1
- Support BigInts for 64-bit numbers above 2 ** 53 HOT 2
- Package information is missing in the [imported] messages. HOT 1
- Is your library CSP friendly? (not using any unsafe eval expression)? HOT 3
- gtfs realtime pbf is empty? HOT 1
- Error: Unimplemented type: 6 HOT 1
- Remove one tag HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pbf.