Comments (6)
The issue is here. https://github.com/mapbox/pbf/blob/master/compile.js#L270
That line should be
if (enumValues && !field.repeated)
I have a fix and test on a fork that I forgot about. I'll submit a PR tomorrow.
from pbf.
@kjvalencik thanks for such a quick fix!
@tyrasd pushed as v3.0.3, can you confirm that it fixes the issue?
from pbf.
@tyrasd pushed as v3.0.3, can you confirm that it fixes the issue?
Not entirely. The default value is fine now, but the data is still read via an obj.types.push(pbf.readVarint())
(as if the field were not defined as [packed = true]
), which produces wrong results (and eventually crashes the parsing). By manually changing that to pbf.readPackedVarint(obj.types);
(which is to be expected from a packed repeated field) everything works fine.
One cause seems to be the delete field.options.packed;
in https://github.com/mapbox/pbf/blob/master/compile.js#L257 (introduced for #57), which overrides the previously present packed
flag of the repeated enum field. Another odd line is https://github.com/mapbox/pbf/blob/master/compile.js#L112 (originating from 7929f12), which should be more similar to how that's implemented in compileRepeatedWrite
a couple of lines below (and, at first glance L111 seems a bit out of place as well).
Here's a very rough patch that works for me and passes all tests (no guarantees, though): tyrasd@4591228
from pbf.
Thanks @tyrasd. Can you give this branch a try? https://github.com/mapbox/pbf/tree/kv/fix-repeated-enums
from pbf.
Yes, the solution in #71 works for me. Thanks!
from pbf.
Released as 3.0.4.
from pbf.
Related Issues (20)
- osm-file processing HOT 1
- Implementing the depreciated start and end groups types HOT 1
- Generate typescript declarations HOT 2
- ENOENT error for valid proto files HOT 2
- Empty string decoded as true as map value HOT 1
- Error using google.protobuf.Any HOT 9
- Performance question HOT 1
- strange coordinates after parser mapbox pbf HOT 1
- Converting pbf to typescript - Both the compiler and the output. HOT 2
- Handling of nulls in writePackedVarint HOT 2
- I use nodejs request module, can not create a Pbf object HOT 1
- pbf is rounding Long Integer values to nearest value why ?
- pbf is rounding the Long integer value to nearest value why? HOT 2
- ESM Support HOT 1
- Support BigInts for 64-bit numbers above 2 ** 53 HOT 2
- Package information is missing in the [imported] messages. HOT 1
- Is your library CSP friendly? (not using any unsafe eval expression)? HOT 3
- gtfs realtime pbf is empty? HOT 1
- Error: Unimplemented type: 6 HOT 1
- Remove one tag HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pbf.