nested packed enums not handled properly about pbf HOT 6 CLOSED

The issue is here. https://github.com/mapbox/pbf/blob/master/compile.js#L270
That line should be

if (enumValues && !field.repeated)

I have a fix and test on a fork that I forgot about. I'll submit a PR tomorrow.

from pbf.

@kjvalencik thanks for such a quick fix!
@tyrasd pushed as v3.0.3, can you confirm that it fixes the issue?

from pbf.

@tyrasd pushed as v3.0.3, can you confirm that it fixes the issue?

Not entirely. The default value is fine now, but the data is still read via an obj.types.push(pbf.readVarint()) (as if the field were not defined as [packed = true]), which produces wrong results (and eventually crashes the parsing). By manually changing that to pbf.readPackedVarint(obj.types); (which is to be expected from a packed repeated field) everything works fine.

One cause seems to be the delete field.options.packed; in https://github.com/mapbox/pbf/blob/master/compile.js#L257 (introduced for #57), which overrides the previously present packed flag of the repeated enum field. Another odd line is https://github.com/mapbox/pbf/blob/master/compile.js#L112 (originating from 7929f12), which should be more similar to how that's implemented in compileRepeatedWrite a couple of lines below (and, at first glance L111 seems a bit out of place as well).

Here's a very rough patch that works for me and passes all tests (no guarantees, though): tyrasd@4591228

from pbf.

Thanks @tyrasd. Can you give this branch a try? https://github.com/mapbox/pbf/tree/kv/fix-repeated-enums

from pbf.

Yes, the solution in #71 works for me. Thanks!

from pbf.

Released as 3.0.4.

from pbf.