Comments (4)
Now that Node.js 10.4+ supports BigInt any chance of revisiting support for this? I'm working with a 3rd party service that unfortunately using int64 to send IDs which doesn't work well trying to stuff into a 32 bit JavaScript int.
from pbf.
I'm not sure... I would probably use something like https://github.com/indutny/bn.js to handle big numbers, but I wouldn't want to pull in such a big dependency for a rare use case like this. Perhaps we could do away with just mentioning this in docs and providing a JS workaround in a gist?
from pbf.
Out of scope for this library for now, keeping it simple.
from pbf.
In order to be backward compatible, it might be worth looking at:
https://developers.google.com/protocol-buffers/docs/reference/java/com/google/protobuf/DescriptorProtos.FieldOptions.JSType
JS_NORMAL would be the current behavior.
JS_NUMBER would parse and return the number as a bigint.
JS_STRING would parse and return as a string
The way compiler would need to make calls to the new functions writeVarintFromBigint / writeVarintFromString / readVarintFromBigint / readVarintFromString.
writeVarintFromString and readVarintFromString could be implemented by calling the Bigint variant and doing a toString value of it.
from pbf.
Related Issues (20)
- osm-file processing HOT 1
- Implementing the depreciated start and end groups types HOT 1
- Generate typescript declarations HOT 2
- ENOENT error for valid proto files HOT 2
- Empty string decoded as true as map value HOT 1
- Error using google.protobuf.Any HOT 9
- Performance question HOT 1
- strange coordinates after parser mapbox pbf HOT 1
- Converting pbf to typescript - Both the compiler and the output. HOT 2
- Handling of nulls in writePackedVarint HOT 2
- I use nodejs request module, can not create a Pbf object HOT 1
- pbf is rounding Long Integer values to nearest value why ?
- pbf is rounding the Long integer value to nearest value why? HOT 2
- ESM Support HOT 1
- Support BigInts for 64-bit numbers above 2 ** 53 HOT 2
- Package information is missing in the [imported] messages. HOT 1
- Is your library CSP friendly? (not using any unsafe eval expression)? HOT 3
- gtfs realtime pbf is empty? HOT 1
- Error: Unimplemented type: 6 HOT 1
- Remove one tag HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pbf.