Git Product home page Git Product logo

Comments (4)

rdominy avatar rdominy commented on August 23, 2024 3

Now that Node.js 10.4+ supports BigInt any chance of revisiting support for this? I'm working with a 3rd party service that unfortunately using int64 to send IDs which doesn't work well trying to stuff into a 32 bit JavaScript int.

from pbf.

mourner avatar mourner commented on August 23, 2024

I'm not sure... I would probably use something like https://github.com/indutny/bn.js to handle big numbers, but I wouldn't want to pull in such a big dependency for a rare use case like this. Perhaps we could do away with just mentioning this in docs and providing a JS workaround in a gist?

from pbf.

mourner avatar mourner commented on August 23, 2024

Out of scope for this library for now, keeping it simple.

from pbf.

UlysseM avatar UlysseM commented on August 23, 2024

In order to be backward compatible, it might be worth looking at:
https://developers.google.com/protocol-buffers/docs/reference/java/com/google/protobuf/DescriptorProtos.FieldOptions.JSType

JS_NORMAL would be the current behavior.
JS_NUMBER would parse and return the number as a bigint.
JS_STRING would parse and return as a string

The way compiler would need to make calls to the new functions writeVarintFromBigint / writeVarintFromString / readVarintFromBigint / readVarintFromString.

writeVarintFromString and readVarintFromString could be implemented by calling the Bigint variant and doing a toString value of it.

from pbf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.