Protect against invalid type access in Convert::calcBBox about geojson-vt-cpp HOT 7 CLOSED

Interesting. How did you determine that it's a null feature?

from geojson-vt-cpp.

Sorry, edited to be more clear above. It looks like a geometry type is being requested that is not inside the variant, not necessarily a null. I don't have a testcase or conclusive proof, just reading the backtrace shows that .get<> is failing which means the requested type does not exist.

from geojson-vt-cpp.

I think the underlying issue is that geojson-vt-cpp wants the invariant that a Point feature always has a ProjectedPoints geometry, and a non-Point feature always has a ProjectedRings geometry. If that's the case, then a fix like #43 is hiding the underlying issue, which is that some other part of the code is violating that invariant.

from geojson-vt-cpp.

@jfirebaugh thanks for the help. I'll close #43 then and we'll wait for more of a sense of the underlying problem.

from geojson-vt-cpp.

I remember @mikemorris having a similar problem very long time ago, but we couldn't get a reproducible test case that time either.

from geojson-vt-cpp.

@mourner Yea, I was trying to diagnose mapbox/mapbox-gl-native#2926 and found the problematic line, but couldn't determine the proper fix.

from geojson-vt-cpp.

Addressed by #45 (with visitor pattern for bbox calculation).

from geojson-vt-cpp.