retrieving a list of "abstracted" entities about rest-client-sdk HOT 5 CLOSED

I just found this comment in the serializer class, line 79 :

// classname may be detected for hydra api with @type key

I guess this explains our issue :)

from rest-client-sdk.

I do not have a great idea about this:

The fact is that the entity is really coupled with the url you use to make the call for now.

A solution could be to allow a callback function to be called to override the default conversion functionality, but it may be complex and lead to bugs and be very coupled with the library, so more BC.

Another solution is to implement a "kind of" inheritance system, like doctrine does but it may be really complex and add a lot of configuration.

If you have a better idea, I will gladly take it as you are more close to the code.

from rest-client-sdk.

I just pushed PR #56 , which is a proposal for the handling of abstract entities, let me know all the adjustments you'd like.

I added unit tests but I never used atoum before, my tests may not be 100% on par with your habits, just let me know.

from rest-client-sdk.

I reviewed you PR, but I think of a nice "quickfix" you can do right now in your code before we fixed it in the API:

You can just override the findBy method like defined in the README

You won't benefit from all the magic behind like the cache system, but you can implement it easily yourself if you need it (you won't need it if you code is clean, but I know we do :) )

The implementation can be something like this:

    public function findBy(array $params) {
        // generate the path to call
        $path = // ...
        $data = $this->restClient->get($path);
        $hydrator = $this->sdk->getModelHydrator();
        $out = [];
        foreact ($data as $item) {
            $entityName = $item['@type'] === 'Bar' ? 'Foo\Bar' : 'Foo\Baz';
            $out[] = $hydrator->hydrate($item, $entityName);  
        }
        return $out;
    }

from rest-client-sdk.

Fixed in v0.21.0.

from rest-client-sdk.