Is your feature request related to a problem? Please describe. I

Hello <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-ur

Support combination of independent discriminator types per inheritance level about jsonsubtypes HOT 2 CLOSED

UtkarshPhilips commented on June 6, 2024

Support combination of independent discriminator types per inheritance level

from jsonsubtypes.

Comments (2)

UtkarshPhilips commented on June 6, 2024

Seems like there is still a workaround. If I remove JsonSubtypesWithPropertyConverterBuilder converter from settings, the deserialization still succeeds in differentiating between Cat and Dog type based on property.

After this, I'm able to successfully deserialize into Cat, BlackDog and WhiteDog classes.

However this could still be a good feature as it can be made a little bit more explicit.

from jsonsubtypes.

manuc66 commented on June 6, 2024

Hello @UtkarshPhilips

I can't reproduce the issue: https://dotnetfiddle.net/TdOd4r

Runnable sample:

```csharp using System; using JsonSubTypes; using Newtonsoft.Json;

    public abstract class Animal
    {
        string LegsCount { get; set; }
    }

    public class Dog : Animal
    {
        public virtual DogColors Color { get; }
        public string Breed { get; set; }
    }

// Leaf Class
public class Cat : Animal
{
public bool Declawed { get; set; }
}

    public enum DogColors
    {
        Black,
        White
    }

// Leaf Class
public class BlackDog : Dog
{
public override DogColors Color { get; } = DogColors.Black;
}

// Leaf Class
public class WhiteDog : Dog
{
public override DogColors Color { get; } = DogColors.White;
}

public class Program
{
public static void Main()
{
var settings = new JsonSerializerSettings();

        settings.Converters.Add(JsonSubtypesWithPropertyConverterBuilder
            .Of<Animal>()
            .RegisterSubtypeWithProperty<Dog>("Breed")
            .RegisterSubtypeWithProperty<Cat>("Declawed")
            .Build());

        settings.Converters.Add(JsonSubtypesConverterBuilder
            .Of<Dog>("Color")
            .RegisterSubtype<BlackDog>(DogColors.Black)
            .RegisterSubtype<WhiteDog>(DogColors.White)
            .Build());
	

        object result;
        result = JsonConvert.DeserializeObject<Animal>("{\n    \"LegsCount\": \"4\",\n    \"Declawed\": true\n}", settings);
        Console.WriteLine(result.GetType());
        result = JsonConvert.DeserializeObject<Animal>("{\n    \"LegsCount\": \"4\",\n    \"Breed\": \"Doberman\",\n    \"Color\": \"Black\"\n}", settings);
        Console.WriteLine(result.GetType());
        result = JsonConvert.DeserializeObject<Animal>("{\n    \"LegsCount\": \"4\",\n    \"Breed\": \"Husky\",\n    \"Color\": \"White\"\n}", settings);
        Console.WriteLine(result.GetType());
        try
        {
            result = JsonConvert.DeserializeObject<Animal>("{\n    \"LegsCount\": \"4\",\n    \"Breed\": \"Chihuahua\"\n}", settings);
            Console.WriteLine(result.GetType());
        }
        catch (Exception e)
        {
            Console.WriteLine(e.Message);
        }
}

}