Jupyter Notebooks don't support Halo about halo HOT 12 CLOSED

This is fixed in #40 thanks to @JungWinter! This will be made available soon in next release. I need to do few fixes before making a release.

from halo.

@HBadertscher This is one feature I would love to include. I feel we would need to create a widget for jupyter notebook and ipython so that spinner renders as expected. I don't have experience with that, hence will take me a while to finalize the fix and get this working.

If you would like to work on this, feel free to take this one up and I will assign it to you.

from halo.

Just adding here. If spinner is started in a cell in iPython and not stopped within the same cell, the spinner cannot be stopped. Need to explore this a little more. A widget might fix this.

from halo.

@manrajgrover Can I try to implement this feature? I don't have experience with ipython and jupyter widget too, but it's so interesting to work.

refer

• tqdm jupyter integration
• tqdm notebook
• widget user guide

from halo.

@JungWinter sure! Please go ahead and give it a try.

from halo.

@manrajgrover I made prototype and can test in notebook.

• First, from ipywidgets import HTML is tried, but problem was happen about color ansi code.
• Second, from ipywidgets.widgets import Output, It's work well now. I overwrite __init__, clear, _render_frame_, start, stop_and_persist.

I checked examples work fine, but not yet contain any jupyter test code.

from halo.

And when I run pylint, SyntaxError occurs. Could you help me to handle this error?
When running tox, py27 and py36 tests are passed, but pylint is failed.

(halo-venv) halo git:feature-notebook ❯❯❯ pylint --errors-only --rcfile=/Users/WinterJ/Github/halo/.pylintrc --output-format=colorized halo
Traceback (most recent call last):
  File "/Users/WinterJ/.pyenv/versions/halo-venv/bin/pylint", line 11, in <module>
    sys.exit(run_pylint())
  File "/Users/WinterJ/.pyenv/versions/3.6.1/envs/halo-venv/lib/python3.6/site-packages/pylint/__init__.py", line 13, in run_pylint
    Run(sys.argv[1:])
  File "/Users/WinterJ/.pyenv/versions/3.6.1/envs/halo-venv/lib/python3.6/site-packages/pylint/lint.py", line 1260, in __init__
    'init-hook')))
  File "/Users/WinterJ/.pyenv/versions/3.6.1/envs/halo-venv/lib/python3.6/site-packages/pylint/lint.py", line 1361, in cb_init_hook
    exec(value) # pylint: disable=exec-used
  File "<string>", line 8
    ZGljdChfX2ZpbGVfXz1hY3RpdmF0ZV90aGlzKSkK'.decode('base64')
                                            ^
SyntaxError: invalid syntax

from halo.

@JungWinter This looks amazing! I'll have a look at the code soon. Regarding lint error, I'll have a look at it as well while going through your code. Could you please check if this works on ipython as well?

from halo.

@manrajgrover Thanks for reviewing! I checked Halo already works well. Although HaloNotebook doesn't work in ipython shell. I think it's not a problem because there is the original halo. If there are any problems I didn't recognize, please let me know.

from halo.

@JungWinter I remember the issue with iPython. If a user does not handle keyboard interrupt and the spinner is running, a KeyboardInterrupt is thrown but the spinner keeps spinning. I'm creating an issue for this.

from halo.

@manrajgrover Oh, I didn't check that issue. I worked a little to solve that problem. Please check my comment. #35 (comment)

from halo.

@JungWinter Please send a PR for this. I'll review the code. 😄 Thank you for working on this!

from halo.