Git Product home page Git Product logo

Comments (14)

thehappydinoa avatar thehappydinoa commented on June 8, 2024 1

I will work on this

from fsociety.

jdrago999 avatar jdrago999 commented on June 8, 2024 1

Hey @jdrago999 I honestly don't know enough about docker, would you be able to make a PR that does this?

Yes I would be happy to push this forward, working with other projects' maintainers as necessary.

from fsociety.

thehappydinoa avatar thehappydinoa commented on June 8, 2024 1

@jdrago999 thank you

from fsociety.

thehappydinoa avatar thehappydinoa commented on June 8, 2024

Ok @jdrago999 I added a Dockerfile, let me know if it works for you

from fsociety.

jdrago999 avatar jdrago999 commented on June 8, 2024

Hey @thehappydinoa I was thinking about it a different way. Usually a container is used for a single tool -- so instead of running pip install beautifulsoup4 && pip install requests in the host OS just so we can install https://github.com/AeonDave/doork it would be better to make sure that doork itself has a properly maintained Dockerfile and a working fsociety/doork Docker image on https://hub.docker.com/

Also, what happens if doork changes and now it requires a different version of requests or beautifulsoup or there are some other libraries required (eg: libcrypto++-dev or libxml2-dev) and simply running pip install beautifulsoup4 && pip install requests no longer works?

By pushing the responsibility of dependency management upstream into Docker containers, we gain the ability to have more reliable tools and reduce overall effort to make things work.

If the maintainers of the various upstream tools (like doork) want to participate in this effort, that would be great.

from fsociety.

thehappydinoa avatar thehappydinoa commented on June 8, 2024

Hey @jdrago999 I honestly don't know enough about docker, would you be able to make a PR that does this?

from fsociety.

mostafahussein avatar mostafahussein commented on June 8, 2024

@jdrago999 I might be able to help on this , But could you explain what are you planning to do ? Are we talking about a separate image for each tool and this case we will have a tool per container ?

from fsociety.

Isanderthul avatar Isanderthul commented on June 8, 2024

fyi trying out the docker commands I get the following error
error.txt

edit: I am on a mac

from fsociety.

jdrago999 avatar jdrago999 commented on June 8, 2024

@mostafahussein:

Are we talking about a separate image for each tool and this case we will have a tool per container?

Yes precisely. And yes I realize that could be a lot of work, but I hope that having each of these tools running within an environment well-suited to them will alleviate the kinds of problems we run into when one tool has requirements that don't play well with another tool's requirements.

from fsociety.

Isanderthul avatar Isanderthul commented on June 8, 2024

I think that will be a maintenance nightmare, putting all the tools in one docker container makes more sense to me, then I can simply mount my ssh keys as an external volume, and any data partitions I want and then run the docker image and attach to it.

from fsociety.

thehappydinoa avatar thehappydinoa commented on June 8, 2024

Hi all thank you so much for all the ideas, I am honestly not the best with docker so if you guys could make PRs as things go on that would be great.

from fsociety.

thehappydinoa avatar thehappydinoa commented on June 8, 2024

@Isanderthul I am unable to view that file, could you create a new issue?

from fsociety.

Isanderthul avatar Isanderthul commented on June 8, 2024

new issue made #12

from fsociety.

alexcreek avatar alexcreek commented on June 8, 2024

here you go #13

from fsociety.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.