Map AWS Tags to MIQ Tags about manageiq-providers-amazon HOT 12 CLOSED

@bronaghs thanks! I realised after I posted that this wasn't all from now! 😂

from manageiq-providers-amazon.

One thing I noticed is that when you create a label and category on the "Map Tags" tab, it scopes the tag name to kubernetes:

"/managed/kubernetes::amazon_label"

I'm guessing we'll need to address that.

from manageiq-providers-amazon.

@djberg96 might be worth checking if the UI is enforcing that.

from manageiq-providers-amazon.

Another possible issue is that when you create a tag/category via the Map Tags tab, it sets the read_only value to true, which means that it won't show up within the UI.

from manageiq-providers-amazon.

We received this feedback from @bascar:

As an enhancement, it would be great if we could pick a specific tag category and auto create the tag value. I am thinking something like:

• AWS Label: "myCompany_department" = "HR"
  If we wild-carded(create if doesn't exist) the category of "myCompany_department" , then it would match to "HR" or create "HR" if it does not exists. That way categories that exhibit a lot of adds dont have to be manually mapped.
• MIQ Mapping: "company_department" = "HR"
  ​

from manageiq-providers-amazon.

"wildcard" is what the container "Map Tags" feature already does.
The mapping is for specific key ("myCompany_department") -> a category, finds or creates tag per value as needed. [*]

ContainerLabelTagMapping class also supports mapping a single value, but that was never documented nor exposed in UI, I'm all for dropping it to simplify the code
(unless you have a use for it. it would complicate the UI, especially logic for deleting mappings & categories. would need someone to decide exact requirements first.)

[*] BTW I forgot to warn you, that tag creation code does some DB locking, might kill your shiny graph refresh performance ;-) https://github.com/ManageIQ/manageiq/blob/a684fcfa52/app/models/container_label_tag_mapping.rb#L74-L94
The motivation was that tags and classifications tables are shared for the region, wanted different providers' refresh workers that want to create same tag to achieve atomic upsert. There are probably better ways.

from manageiq-providers-amazon.

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

from manageiq-providers-amazon.

@cben Where are we on this?

from manageiq-providers-amazon.

One thing I noticed is that when you create a label and category on the "Map Tags" tab, it scopes the tag name to kubernetes:

In my db I have /managed/amazon:vm:santa

from manageiq-providers-amazon.

@juliancheal - I too get the correct value in the taggings table: /managed/amazon:vm:aws_tier
I think the comment Dan made was fixed, he made it on March 7th.

from manageiq-providers-amazon.

@cben Where are we on this?

You tell me :-)
I believe this issue could have been closed — it has all worked at some stage.
However now tag mapping is broken in amazon — https://bugzilla.redhat.com/show_bug.cgi?id=1506404 , I'm not sure if that's just because of switch to graph refresh (expected) or also broken in classical refresh — details on the BZ.

I'm happy to help next week, but need a failing test or at least VCR / sample of refresh parser inputs to work on this.

from manageiq-providers-amazon.

Looks like https://bugzilla.redhat.com/show_bug.cgi?id=1506404 was moved to POST. Can we close this?

from manageiq-providers-amazon.