Git Product home page Git Product logo

Comments (4)

abonas avatar abonas commented on August 16, 2024

This is caused by kubernetes/kubernetes#5491

from kubeclient.

abonas avatar abonas commented on August 16, 2024

cc @Fryguy

from kubeclient.

Fryguy avatar Fryguy commented on August 16, 2024

I think it's ok to blow up with a JSON parse error on 404. Alternately, you could catch that error in the handling_kube_exception method, and then translate it to a RestClient::ResourceNotFound error if you see "404: Page Not Found" in the page text (or maybe RestClient has a .http_code == 404 which you could check)

from kubeclient.

abonas avatar abonas commented on August 16, 2024

I think it's ok to blow up with a JSON parse error on 404. Alternately, you could catch that error in the handling_kube_exception method, and then translate it to a RestClient::ResourceNotFound error if you see "404: Page Not Found" in the page text (or maybe RestClient has a .http_code == 404 which you could check)

the problem is that Json.parse fails, and it's hard to predict on which exception it will fail since it wasn't jsonized. For now I am aware of 404 and 500 but there might be more that we'll have to keep track of, to differentiate them from a real non valid json response that might be returned.

from kubeclient.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.