Mock version dependency about arctic HOT 9 CLOSED

Spoke to @mildbyte, he's going to unpin it on a branch and see if any problem arises.

from arctic.

Have fiddled around with CircleCI's setting. This build is done with mock==1.3.0 and it failes with a bunch of test. Will need to fix those tests before we can upgrade it.

from arctic.

P.S. This probably blocks #89

from arctic.

yeah I'm looking into it. Most the errors are things like wrong number of arguments, so I'm guessing some of the methods in mock just changed signature

from arctic.

did some research, this is the issue. The problem is that the method that is called (self.set_library_metadata) is wrapped with a decorator. Take off the decorator, and it works. This is the issue, filed with Mock:

testing-cabal/mock#338

from arctic.

really the issue is in the backport of funcsigs to Python2. I opened this issue:

aliles/funcsigs#21

from arctic.

here is an example that reproduces the issue:

import mock
from functools import wraps

def dec(f):
    @wraps(f)
    def f_2(*args, **kwargs):
        pass
    return f_2


class Example(object):
    def __init__(self):
        pass

    @dec
    def method_1(self, arg):
        pass

    def method_2(self, arg):
        self.method_1(arg)



def test_example():
    m = mock.create_autospec(Example)
    Example.method_2(m, "hello")
    m.method_1.assert_called_once_with("hello")

from arctic.

Someone answered the question I posted on stack overflow. They explain why the above will not work and propose a work around, that does work, but isn't really ideal since you'd still have to instantiate the object,

http://stackoverflow.com/questions/34800832/issue-mocking-with-a-decorated-method-call-in-python-2-7/34811786#34811786

from arctic.

This has been resolved in the python 3 branch. I figured out a workaround thanks to an answer on the SO post.

from arctic.