Git Product home page Git Product logo

Comments (10)

maitrungduc1410 avatar maitrungduc1410 commented on May 25, 2024 2

if sdk version is the problem, you can override it in your android/build.gradle > buildscript > ext

buildscript {
    ext {
        LoaderKit_compileSdkVersion = 34
        LoaderKit_minSdkVersion = 26
        LoaderKit_targetSdkVersion = 34
    }

from react-native-loader-kit.

DarkShtir avatar DarkShtir commented on May 25, 2024 1

RN 0.73.7, and last version of react-native-loader-kit

from react-native-loader-kit.

maitrungduc1410 avatar maitrungduc1410 commented on May 25, 2024 1

maybe this can help you: yamill/react-native-orientation#396 (comment)

from react-native-loader-kit.

GonzaArts avatar GonzaArts commented on May 25, 2024 1

Reviewing everything I have already tried it and it worked for me too.

Thanks @maitrungduc1410 @DarkShtir

from react-native-loader-kit.

DarkShtir avatar DarkShtir commented on May 25, 2024

Same issue

from react-native-loader-kit.

maitrungduc1410 avatar maitrungduc1410 commented on May 25, 2024

@DarkShtir which version of RN are you using?

from react-native-loader-kit.

maitrungduc1410 avatar maitrungduc1410 commented on May 25, 2024

hi @GonzaArts @DarkShtir on which command are you guys facing this issue?

Just now I tested with these commands, they're all fine:

npx react-native build-android --mode=release
npm run android -- --mode="release"

My env (MacOS M2):

"react": "18.2.0",
"react-native": "0.74.0",
"react-native-loader-kit": "^2.0.8"

from react-native-loader-kit.

DarkShtir avatar DarkShtir commented on May 25, 2024

I'm using fastlane to create builds, and under hood fastlane is using ./gradlew assembleRelease -p command

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-loader-kit/android/build.gradle b/node_modules/react-native-loader-kit/android/build.gradle
index d94248d..fed1ef9 100644
--- a/node_modules/react-native-loader-kit/android/build.gradle
+++ b/node_modules/react-native-loader-kit/android/build.gradle
@@ -18,10 +18,10 @@ def safeExtGet(prop, fallback) {
 }
 
 android {
-    compileSdkVersion safeExtGet('LoaderKit_compileSdkVersion', 30)
+    compileSdkVersion safeExtGet('LoaderKit_compileSdkVersion', 34)
     defaultConfig {
-        minSdkVersion safeExtGet('LoaderKit_minSdkVersion', 16)
-        targetSdkVersion safeExtGet('LoaderKit_targetSdkVersion', 30)
+        minSdkVersion safeExtGet('LoaderKit_minSdkVersion', 26)
+        targetSdkVersion safeExtGet('LoaderKit_targetSdkVersion', 34)
         versionCode 1
         versionName "1.0"

Thanks maitrungduc1410 to link

from react-native-loader-kit.

DarkShtir avatar DarkShtir commented on May 25, 2024

Thanks, this is great solution and it's working!
Maybe be useful add this information to troubleshooting article

from react-native-loader-kit.

maitrungduc1410 avatar maitrungduc1410 commented on May 25, 2024

Great, I'm gonna add a troubleshoot section in readme

from react-native-loader-kit.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.