might have issue with destroyed objects about ember-classy-computed HOT 4 OPEN

Thanks for the heads-up. I'm not sure ember-classy-computed could run into this though as we're never observing anything on the context. If a CP class observes anything on the context that observer would have to be removed when the context is destroyed of course but that's outside of our control. I guess that would best be fixed by providing documentation.

I'll certainly investigate this (when I find the time…) to be sure we're safe here!

from ember-classy-computed.

OK I remember now that I changed the observer to watch the context instead of the internal class. What about memory leaks? The weakmap never gets cleared out, so destroyed contexts get stored there forever?

from ember-classy-computed.

I think the idea of WeakMaps is that they clear the key and value once the key object is destroyed.

from ember-classy-computed.

@kellyselden I think your project (ember macro helpers) might also behaves incorrectly in case of dynamically setting computed properties on context object. Please refer to my PR to learn more about the issue.

from ember-classy-computed.