Format code according to Python recommendations - PEP 8 about mailpile HOT 14 CLOSED

+1. PEP8 is practically universally accepted.

Even if you don't adopt PEP8, you should define/document your coding standard conventions in order to allow contributions to be consistent with the existing code base.

from mailpile.

+1 I would be strongly in favour of PEP8 also.

from mailpile.

+1

from mailpile.

+1

Could please someone from core Mailpile developers take a look at this? External contribution is not easy because the diff would be huge, and there is even a security risk because of that.

from mailpile.

We are going to slowly move in this direction. New source files will be PEP 8 compliant and we'll be cleaning up the old ones a little bit at a time.

from mailpile.

Since @markberger has said he doesn't have enough time to keep working on this issue, I'd be glad to take over and help making old files compliant with PEP8 (there's also some pyflakes cleanup to be done). I agree with @kmike that this is going to produce huge diffs, so maybe we could do it little by little, on file at a time. What do you think?

from mailpile.

After formatting the one file, I would recommend committing indentations
and code changes seperately. That way it is clear what lines of code have
been changed.

On Thursday, September 19, 2013, Gabriel Rodríguez Alberich wrote:

Since @markberger https://github.com/markberger has said he doesn't
have enough time to keep working on this issue, I'd be glad to take over
and help making old files compliant with PEP8 (there's also some pyflakes
cleanup to be done). I agree with @kmike https://github.com/kmike that
this is going to produce huge diffs, so maybe we could do it little by
little, on file at a time. What do you think?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/37#issuecomment-24746096
.

from mailpile.

@vibragiel : Thank you for the generous offer. I only hesitate to take you up on it because we are still doing extensive refactoring and stuff is getting reorganized a lot. We may circle back and accept your offer in a couple of weeks if/when things settle down a bit.

@markberger : Agreed!

from mailpile.

@BjarniRunar Okay, we can do that. I'm used to convert code into PEP8, so I don't think it will take too long to get all of Mailpile worked out. Just give me a whistle when you feel ready :-)

from mailpile.

I would like to help with this task. Please let me know if you need any help on this matter.

from mailpile.

Thanks @jventuravs !

However, as discussed in #244, we have come to the conclusion that it is better for the core team to do the majority of this work, all the changes need to be reviewed by a core member for security reasons and for routine and semi-automated changes that most pep8 fixes are, it's actually a lot easier for us to just do the work ourselves than review and merge pull requests.

We have actually already made good progress, about half the files now comply with the tests from the Debian 7.2 version of the pep8 tool.

from mailpile.

Great, thanks for the heads up. Will be looking for some other way to contribute. Great project by the way, can't wait to use it!

from mailpile.

FYI: a collegue of mine showed a trick to remove whitespace changes from github diff: add w=1 to URL. Compare https://github.com/pagekite/Mailpile/pull/62/files?w=1 and https://github.com/pagekite/Mailpile/pull/62/files

from mailpile.

As of commit e1dd83e, the pep8 tool as shipped with Ubuntu 13.10 has virtually no complaints. I am closing this issue, we'll periodically rerun the tool and fix things that drift out of line.

from mailpile.