Operations should check for nil Completion blocks about mailcore2 HOT 4 CLOSED

Hello,
Could you be more specific? Could you give some example?
I think that a nil completion block is ok.

from mailcore2.

I think what he meant was that you can't call blocks like Objective-C objects, where sending messages to nil is harmless. It would probably be a good idea to check to see whether self.completionBlock is nil before attempting to send it messages, since otherwise it will crash.

Is that what you were trying to say, @CodaFi?

from mailcore2.

@jwilling Spot on.

from mailcore2.

For example, in MCOCheckAccountOperation, the operation callback plows ahead and calls it's completion block. If the block were static (I.e. immutable or pre-defined), then it wouldn't be a problem, but because the completion block is explicitly set in the -start: method, I think it's best to check for nil every time.

- (void)operationCompleted {
    IMAPOperation *op = dynamic_cast<IMAPOperation *>(self.operation);
    NSError *error = [NSError mco_errorWithErrorCode:op->error()];
    self.completionBlock(error);  //dangerous
}

from mailcore2.