Git Product home page Git Product logo

Comments (3)

mahmoud avatar mahmoud commented on May 18, 2024 1

#114 is merged and a release is forthcoming. Thank you both for the report and the great fixes!

from boltons.

induane avatar induane commented on May 18, 2024

I can see two potential solutions to this @doroncohen:

The first is to make the resulting dictionary contain string instances of _DeferredLine. After all, the docstring for to_dict says "Get a :class:dict copy of the Callpoint. Useful for serialization."

This would effectively change the API though; I'm not sure what @mahmoud feels in regards to API stability here. There is always a slim chance this could break things for someone who is using to_dict in an unconventional or unexpected way.

This leaves another option: Provide a to_json method for all Callpoint object instances. This would result in a stable API and JSON serialization support. Potentially handy.

I actually lean towards the first solution personally because it seems weird to have a class designed for serialization that can't actually be easily serialized.

To that end I've created two pull requests, each implementing one version of the fix.

#113

and

#114

Really I'm not in a position to make the call here, but I figured it was easy enough to provide both potential solutions and let the boltons maintainers make a call.

from boltons.

mahmoud avatar mahmoud commented on May 18, 2024

Yeah, I'm probably the most extensive user of this API, but having gone through all my uses, they all stringify the DeferredLine, so not only won't the first solution break my code, but it probably should have been built-in to begin with. I'm going to do some more testing before release, but for now I think I'm going to go with #114.

from boltons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.