I have gone through the code & want to propose the addition of openings & endi

Also the addition on _titlesysnonmys() in <code class

A minor improvement in the above methods <div class="snippet-clipboard-content not

Addition of Opening & Endings in Anime Page about myanimelist-api HOT 4 CLOSED

Sher1234 commented on May 30, 2024

Addition of Opening & Endings in Anime Page

from myanimelist-api.

Comments (4)

magnum357i commented on May 30, 2024 1

I'll add what you said in the new version. I'm handling issues reported in codaacy right now. I'll release it in a few days.

from myanimelist-api.

Sher1234 commented on May 30, 2024

Also the addition on _titlesysnonmys() in \myanimelist\Page\Manga

from myanimelist-api.

Sher1234 commented on May 30, 2024

A minor improvement in the above methods

if (count($data) == 1 && $data[0] == "") return FALSE;
return static::setValue($key, $data);

It earlier provides an array with single empty string for no opening & endings
Add this at the end of both the functions.

Output:

"openings": [
    "#01: \"Mune ga Dokidoki (胸がドキドキ)\" by the High-Lows (eps 1-30)",
    "#02: \"Feel Your Heart\" by Velvet Garden (eps 31-52)",
    "#03: \"Nazo (謎)\" by Miho Komatsu (小松未歩) (eps 53-96)",
    "#04: \"Unmei no Roulette Mawashite (運命のルーレット廻して)\" by ZARD (eps 97-123)",
    "#05: \"Truth\" by Two-Mix (eps 124-142)",
    "#06: \"Girigiri Chop (ギリギリchop)\" by B&#039;z (eps 143-167)",
    "#07: \"Mysterious Eyes\" by Garnet Crow (eps 168-204)"
]

from myanimelist-api.

magnum357i commented on May 30, 2024

Added. Thanks for help. 💯

(Just made a more detailed output in songs)

You can open a different ticket if you have another request. See you there. 😃

from myanimelist-api.

Recommend Projects