If the string contains a substring that is equal to one of the keys of the <code class

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

s-replace-all case-issue about s.el HOT 3 CLOSED

twmr commented on September 28, 2024

s-replace-all case-issue

from s.el.

Comments (3)

jasonm23 commented on September 28, 2024

@syohex any ideas on this one? (Error tested and reproduced.)

from s.el.

syohex commented on September 28, 2024

Sorry I don't remember anything about this. How about using CASE-FOLD argument of assoc-string as below ?

diff --git a/s.el b/s.el
index ba6c1ed..f1dfe9c 100644
--- a/s.el
+++ b/s.el
@@ -400,7 +400,7 @@ This is a simple wrapper around the built-in `string-match-p'."
 
 (defun s--aget (alist key)
   (declare (pure t) (side-effect-free t))
-  (cdr (assoc-string key alist)))
+  (cdr (assoc-string key alist case-fold-search)))
 
 (defun s-replace-all (replacements s)
   "REPLACEMENTS is a list of cons-cells. Each `car` is replaced with `cdr` in S."

from s.el.

jasonm23 commented on September 28, 2024

@syohex @magnars turns out it's a silly error, if the replacement lamba comes up with nil it's going to send that back to replace-regexp-in-string

So I've added a condition to avert the problem...

(defun s-replace-all (replacements s)
  "REPLACEMENTS is a list of cons-cells. Each `car` is replaced with `cdr` in S."
  (declare (pure t) (side-effect-free t))
  (replace-regexp-in-string
   (regexp-opt (mapcar 'car replacements))
   (lambda (it)
     (let ((replacement (s--aget replacements it)))
       (if (null replacement)
           it
         replacement)))
   s t t))