Git Product home page Git Product logo

Comments (14)

magicsunday avatar magicsunday commented on July 24, 2024

Are the images of the individuals loaded correctly?
Did the silhouette images got loaded in the previous version?

Please try the latest version from master branch. I added some error logging to the image loading method. Do you get any errors in the console log?

I do not get any errors in my Firefox and Edge.

from webtrees-pedigree-chart.

TheDutchJewel avatar TheDutchJewel commented on July 24, 2024

Are the images of the individuals loaded correctly?

Which images? I don't use images.
Or do you mean the silhouette images in the standard pedigree chart and on the individual page?
These are displayed correctly. The only incorrect displayed images are the silhouette images in your nice Pedigree chart.

Did the silhouette images got loaded in the previous version?

I didn't test the initial release, only v1.1.0.
But now also tested in v1.0.0: same problem.

Please try the latest version from master branch.

Done. Same problem.

I added some error logging to the image loading method. Do you get any errors in the console log?

Here's the content of the console log in Edge:

vendor.min.js?v=2.0.11:2 [Deprecation] Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.

send @ vendor.min.js?v=2.0.11:2
ajax @ vendor.min.js?v=2.0.11:2
T._evalUrl @ vendor.min.js?v=2.0.11:2
Re @ vendor.min.js?v=2.0.11:2
append @ vendor.min.js?v=2.0.11:2
(anonymous) @ vendor.min.js?v=2.0.11:2
U @ vendor.min.js?v=2.0.11:2
html @ vendor.min.js?v=2.0.11:2
(anonymous) @ vendor.min.js?v=2.0.11:2
l @ vendor.min.js?v=2.0.11:2
fireWith @ vendor.min.js?v=2.0.11:2
x @ vendor.min.js?v=2.0.11:2
(anonymous) @ vendor.min.js?v=2.0.11:2
load (async)
send @ vendor.min.js?v=2.0.11:2
ajax @ vendor.min.js?v=2.0.11:2
T.fn.load @ vendor.min.js?v=2.0.11:2
(anonymous) @ webtrees.min.js?v=2.0.11:1
each @ vendor.min.js?v=2.0.11:2
each @ vendor.min.js?v=2.0.11:2
(anonymous) @ webtrees.min.js?v=2.0.11:1
u @ vendor.min.js?v=2.0.11:2
c @ vendor.min.js?v=2.0.11:2
setTimeout (async)
(anonymous) @ vendor.min.js?v=2.0.11:2
l @ vendor.min.js?v=2.0.11:2
fireWith @ vendor.min.js?v=2.0.11:2
fire @ vendor.min.js?v=2.0.11:2
l @ vendor.min.js?v=2.0.11:2
fireWith @ vendor.min.js?v=2.0.11:2
ready @ vendor.min.js?v=2.0.11:2
q @ vendor.min.js?v=2.0.11:2

Here's the content of the console log in Firefox:

Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user’s experience. For more help http://xhr.spec.whatwg.org/

from webtrees-pedigree-chart.

magicsunday avatar magicsunday commented on July 24, 2024

Strange. Maybe you can give me access to the site so that I can see for myself?

from webtrees-pedigree-chart.

TheDutchJewel avatar TheDutchJewel commented on July 24, 2024

I sent you an email with the link.

from webtrees-pedigree-chart.

magicsunday avatar magicsunday commented on July 24, 2024

I didn't get any email.

from webtrees-pedigree-chart.

TheDutchJewel avatar TheDutchJewel commented on July 24, 2024

Oops, I sent it to the wrong Ric...

New mail sent to you.

Anyway, I just installed a fresh webtrees as test, with only your Fan and Pedigree chart modules.

And I found something interesting: photos are displayed correctly, silhouette images are not displayed!

I've added two trees with a dummy info, one with and one without photos.

I tested your Pedigree chart on both trees:
tree with photos:
-> photos are displayed correctly.

tree without photos:
-> silhouette images are not displayed, while they are displayed correctly in the Fan chart.

I hope this will help to solve the problem.

from webtrees-pedigree-chart.

magicsunday avatar magicsunday commented on July 24, 2024

Ok. Seems a problem with the pretty URLs I dont use until now.

There is also a bug in webtrees: fisharebest/webtrees#3665 preventing the display of SVG images.

from webtrees-pedigree-chart.

magicsunday avatar magicsunday commented on July 24, 2024

I changed the way returning the images from the module. Now its up to webtrees to return the correct mime type for SVG images in order to display them correctly..

from webtrees-pedigree-chart.

magicsunday avatar magicsunday commented on July 24, 2024

With latest webtrees master and with latest master from this repo, the error should be fixed.

from webtrees-pedigree-chart.

06Games avatar 06Games commented on July 24, 2024

Even with the last commit, I also encounter this bug. This was not happening with the code of my pull request. You must have changed something that you shouldn't have in the meantime ;)
I will look tomorrow if I can fix that

from webtrees-pedigree-chart.

06Games avatar 06Games commented on July 24, 2024

After investigation, it seems that in my case, it is 8237be7 which caused the problem.
Before this one, I do not encounter any problem.
Hoping that your pull request fixes the problem of loading SVGs from assetUrl but with Webtrees 2.0.10 it doesn't work

from webtrees-pedigree-chart.

magicsunday avatar magicsunday commented on July 24, 2024

@TheDutchJewel Did it work for you?

from webtrees-pedigree-chart.

magicsunday avatar magicsunday commented on July 24, 2024

@06Games You have to use latest version from master-branch of webtrees as this contains the fix. fisharebest/webtrees@91694fa

from webtrees-pedigree-chart.

TheDutchJewel avatar TheDutchJewel commented on July 24, 2024

@magicsunday Yes, the latest version from the master-branch works fine with the latest webtrees master. Thanks for fixing!

And thanks to the fix you mentioned, I can use your Pedigree chart in the stable webtrees version too!

from webtrees-pedigree-chart.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.