Git Product home page Git Product logo

Comments (11)

aryanraj60 avatar aryanraj60 commented on May 18, 2024

Hello! I would like to take ownership of this issue and work on resolving it. Could you please assign it to me? Thank you!

from catalog.

alexdanilowicz avatar alexdanilowicz commented on May 18, 2024

Hey @aryanraj60 go for it! Please first join our slack channel: https://join.slack.com/t/mirrorful/shared_invite/zt-1ps2xtxh0-2NaixFfFzSKZbr5gw_AHfA

And after forking the repo, here's how you can get set up:

➜  mirrorful git:(main) ✗ cd packages/mirrorful/editor
➜  mirrorful git:(main) ✗ git checkout -b "aryanraj/issue-58"
➜  mirrorful git:(paul/issue-53) ✗ yarn; cd editor; yarn; cd .. # install packages
➜  mirrorful git:(paul/issue-53) ✗ yarn run local # runs mirrorful locally

$ rm -rf ./dist; tsc --build; cross-env NODE_ENV=development node ./dist/cli/index.js
Running Mirrorful version: 2.0.19
Starting Mirrorful in /Users/zeus/code/mirrorful/packages/mirrorful.


Visit: http://localhost:5050/
Inside your project, you can run:

  yarn run mirrorful

to start the visual editor at any time 🚀

Then, you can make changes in code, and once done, open a PR for your changes. Let us know if any questions!

from catalog.

alexdanilowicz avatar alexdanilowicz commented on May 18, 2024

Hi @aryanraj60 are you working on this? Let us know!

from catalog.

airdward avatar airdward commented on May 18, 2024

Can I take this up?

from catalog.

alexdanilowicz avatar alexdanilowicz commented on May 18, 2024

Sure go for it @iamoghenerukevwe !

from catalog.

airdward avatar airdward commented on May 18, 2024

Does it need to be assigned to me?

from catalog.

alexdanilowicz avatar alexdanilowicz commented on May 18, 2024

Going to clear the assignments, any one is welcome to open a PR for this!

from catalog.

alexdanilowicz avatar alexdanilowicz commented on May 18, 2024

@iamoghenerukevwe go for it!

from catalog.

architectDrivenKenny avatar architectDrivenKenny commented on May 18, 2024

I'm currently looking into this as well and the issue is that the nameThatColor function is not able to generate a name for a specific combination of h, l, s. Would it be possible to get more clarity on what the current checks are based on? -

if (s <= 0.1 && l >= 0.9) {
  return 'White'
} else if (l <= 0.15) {
  return 'Black'
} else if ((s <= 0.1 && l <= 0.7) || s === 0) {
  return 'Gray'
} else if ((h >= 0 && h <= 15) || h >= 346) {
  return 'Red'
} else if (h >= 16 && h <= 35) {
  if (s < 0.9) {
    return 'Brown'
  } else {
    return 'Orange'
  }
} else if (h >= 36 && h <= 54) {
  if (s < 0.9) {
    return 'Brown'
  } else {
    return 'Yellow'
  }
} else if (h >= 55 && h <= 165) {
  return 'Green'
} else if (h >= 166 && h <= 260) {
  return 'Blue'
} else if (h >= 261 && h <= 290) {
  return 'Purple'
} else if (h >= 291 && h <= 345) {
  return 'Pink'
}
return 'Unknown' 

from catalog.

Teddarific avatar Teddarific commented on May 18, 2024

Hey @ktra99! This block of code is effectively trying to capture all the different combinations of h,l and s and maps them to a color name. I think the best way to debug this would actually be to write a for loop that goes through every combination of h, l, s to determine what ranges are missing from this block (that was pretty much copied from Stack Overflow). For example,

for (let s = 0; s < 1; s += 0.1){
   for (let h = 0; h < 360; h += 1){
       for (let l = 0; l < 0.1; l += 0.1){
            if ( nameThatColor(h, s, l) === 'Unknown' ){
                  console.log(h, s, l)
            }
       }
   }
}

from catalog.

alexdanilowicz avatar alexdanilowicz commented on May 18, 2024

Linking this discussion to this PR opened by Paul: #182

from catalog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.