Git Product home page Git Product logo

Comments (8)

Teddarific avatar Teddarific commented on May 18, 2024 1

The UI needs to be updated for this one —

I think this will be an awesome addition, but let me take a stab at it in Figma before we touch any code!

from catalog.

alexdanilowicz avatar alexdanilowicz commented on May 18, 2024

Thanks for making the issue, I've been thinking about variants being auto-generated for the exact reason you describe... will do some thinking. Let me know if you have any other thoughts because I totally agree with you!

from catalog.

arneesh avatar arneesh commented on May 18, 2024

Ah, yes agreed. Auto-generated variants seem like a great idea. I guess both of these things can be added.

Once a user chooses a color:

  • Show the user a suggestion of auto-generated variants. Something like "suggested variants".
  • And then there can be an option for inputting your own variants. (for people who already have a basic design system in place and want to migrate to mirrorful)

Design-wise it can be simple for an initial phase - a radio button based block selector, where:

  • "Suggested Variants" option is pre-selected and it shows the list of selected variants

    • #A4EA7A [the color square]
    • #DAF7C9 [the color square]
  • When it is toggled to "Input custom variants"
    Then we could give them a block where they paste their js object (or some other format) to insert multiple variants at once.

from catalog.

prichter avatar prichter commented on May 18, 2024

Could I make an alternate suggestion? If we had a pop-up menu for each variant box and the add variant box, you could perform tasks such as delete, set as base, or add default variants in one click without necessarily having to go through the modal, and have an edit option allowing access to the modal. The modal could then handle entry of multiple values in a list of desired... Thoughts?

from catalog.

prichter avatar prichter commented on May 18, 2024

https://www.loom.com/share/76ab642b459f4189acc21d2561ae71d7
Would something like this meet the need? There is a menu option for manually adding key/value pairs (not yet implemented)...

from catalog.

alexdanilowicz avatar alexdanilowicz commented on May 18, 2024

Will leave to @Teddarific to chime in. I like your Loom Paul!

from catalog.

alexdanilowicz avatar alexdanilowicz commented on May 18, 2024

I would say this issue is still open, but we did move one step closer in: #189 by adding a check box to "automatically generate variants" in PR #189 .

from catalog.

alexdanilowicz avatar alexdanilowicz commented on May 18, 2024

Closed because we're moving to a model where you don't edit variants.

from catalog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.