Git Product home page Git Product logo

Comments (8)

ai avatar ai commented on June 27, 2024

I though about it too, but postcss-modules is used before concat, but cssnano works after concat :(. So it will works only if we concat files by postcss-import.

Anyway we should think about addition way. For example we use selectors rules to find isolation classes. Like we can use rule: 'bem' and then .logo__name and .menu__name will be isolated.

But I think we should give a two ways. Result#messages is useful too.

from postcss-modules.

ai avatar ai commented on June 27, 2024

@ben-eb also @Outpunk in on vacation right now (baby).So I think we should implement some logic in cssnano before postcss-modules fixes. I can help you with postcss-modules PR.

from postcss-modules.

ben-eb avatar ben-eb commented on June 27, 2024

We already have the additional way, the existing getJSON function. I thought it might be nice to keep it all in a single PostCSS instance with, of course, the caveat that you have to use postcss-import. 😄

from postcss-modules.

michael-ciniawsky avatar michael-ciniawsky commented on June 27, 2024

We need result.messages support for postcss-loader. @Outpunk could you point me to where the mappings (JSON) are generated ? 😛

from postcss-modules.

madyankin avatar madyankin commented on June 27, 2024

@michael-ciniawsky Actually, the plugin uses css-modules-loader-core's parser. So, we need to modify the parser to add the API.
https://github.com/css-modules/postcss-modules/blob/master/src/index.js#L82
https://github.com/css-modules/css-modules-loader-core/blob/master/src/parser.js

I'll be happy if you make a PR for this, because I have no time to make it.

from postcss-modules.

michael-ciniawsky avatar michael-ciniawsky commented on June 27, 2024

I'll be happy if you make a PR for this, because I have no time to make it.

Yep, of course 😛

css-loader-core/lib/parser.js

  plugin( css, result ) {
    return Promise.all( this.fetchAllImports( css ) )
      .then( _ => this.linkImportedSymbols( css ) )
-     .then( _ => this.extractExports ( css ) )
+     .then( _ => {
+        this.extractExports( css ) 
+        result.messages.push({ type: 'modules', modules: this.exportTokens })
+     })
   }

?

from postcss-modules.

madyankin avatar madyankin commented on June 27, 2024

Looks awesome!

from postcss-modules.

carlhopf avatar carlhopf commented on June 27, 2024

👍 Would be awesome to access the mappings through result.messages! :)

from postcss-modules.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.