Expose Underlying Context in Goon type? about goon HOT 4 CLOSED

It sounds ok to me. Let's consider if there's a better API. How about making the context exported? This allows for the above functionality without a getter function (which I favor). However it does expose this, so it can be changed (which could cause problems, but we can document that and don't have to make guarantees). Are there any downsides to that?

from goon.

Yeah I was wondering about making the Context public, so changing the Goon definition to:

type Goon struct {
    Context      appengine.Context
    ...
}

But my concern as well was people being able to mess with the Context, which concerned me, hence my use of the getter.

That's the only issue I had. But yeah, if we document it, I'm not seeing a huge issue.

from goon.

Considering that this is legal (although it panics):

package main

import "net/http"

func main() {
    http.DefaultClient = nil
    http.Get("http://google.com")
}

it seems that the Go style is accessor methods aren't worth it because the programmer is already supposed to know what to do. Unless other evidence is presented, I'm in favor of exporting it.

from goon.

👍 Agreed. I'll get hacking on it, should be an easy change.

from goon.