Comments (3)
macosforgebot
commented on July 28, 2024
contact@… originally submitted this as comment:1:ticket:12
I've made changes to check for supported WAV PCM bit depth (i.e., reject anything that's not 16- or 24-bit).
It's my first time submitting changes to MacOSforge — are there any guidelines regarding code review before committing, &cet.? Thanks!
from alac.
macosforgebot
commented on July 28, 2024
contact@… originally submitted this as attachment:patch.main.cpp:ticket:12
- Attachment patch.main.cpp (1.4 KB) added
Patch for convert-utility/main.cpp
from alac.
AngeloStavrow
commented on July 28, 2024
Should I fork and re-submit the patch as a pull request?
EDIT: Ah, wait. I'm only patching the convert utility, not the encoder itself. Will fix.
from alac.
Related Issues (20)
- [convert_utility] typo in logical expression in main.cpp HOT 2
- encoder segfaults on 20-bit wav
- header building seems to be potential broken HOT 1
- M4A files not handled HOT 3
- Dynamic Library?
- CAFFileALAC.h is missing needed layout tags from CoreAudioTypes
- Testing/Certification requirements of ALAC codec
- ⚠️ Please add a version tag the latest stable release
- M4A files as output not supported
- Severe Remote Code Execution vulnerability HOT 4
- what a load of nonsense
- ALAC encoder produces invalid bitstream on Apple Silicon(in native mode)
- License is ambiguous (Apache or Apple Public Source License)
- Cannot build alacconvert under Slackware 13.37: makefile problem? HOT 2
- magic cookie is incorrect on little endian host
- convert-utility can't build on MinGW HOT 1
- Definition of kALACChannelLayoutTag_MPEG_3_0_B is incorrect HOT 1
- Patch to fix sign-compare warnings HOT 1
- Missing initializer build warnings
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from alac.