Comments (3)
i think i was a little hasty in pushing this code.
i see what the issue is after looking closer.
you want to take src
update management out of the component and control changes externally (using callbacks and re-renders).
the reason why src
is managed by state
rather than just props
is because the component handles src
internally once it's been rendered. that idea was to make onEdit
, onAdd
and onDelete
work out of the box.
I'm going to undo the change via pr #99 and open this issue back up.
HOWEVER - your changes are consistent with standard react design patterns.
I'm going to work on controlling src
with props
only and indicate the change with a major version update (2.0.0).
that will allow me to remove all the state management complexity and hopefully get rid of ObjectAttributes
global storage. the only downside is that users will have to intentionally capture edits via callback methods, update src
prop and rerender the component to get edits working.
The downside is an upside. This is the type of behavior i'd expect from a react component.
more on this to come. I published 1.11.5 to npm with your changes. you can use that for now.
from react-json-view.
before I make test-breaking changes, can you test out #100 and let me know if it solves the original issue you pointed out?
from react-json-view.
#100 works great for me! Thanks!
from react-json-view.
Related Issues (20)
- Supply chain attack?
- Updating peer dependencies to allow for NodeJS 18 and 19 HOT 2
- src property must be a valid json object while waiting for Promise to resolve HOT 1
- how to hide the date-value when I edit
- 为什么数据展示会很乱 HOT 2
- Doesn't support React 18? HOT 15
- Adding clickable url that can redirect user HOT 1
- Long word overflow HOT 2
- API name property is deprecated and should be updated to rootName HOT 3
- Disable collapse buttons HOT 1
- NULL should be lowercased HOT 1
- why not support custom DOM, can i develop more under the code? i really need HOT 1
- onEdit icons HOT 1
- Project no longer maintained, take this one. HOT 2
- Controls present in the code section are not accessible using keyboard. HOT 2
- Yet another alternative 😁
- Keyboard focus is going on background element when navigating under 'Transform' dialog box. HOT 1
- Add Id to the section element HOT 1
- Consider accepting string formatted in JSON instead of JavaScript object for src HOT 1
- ReferenceError: document is not defined HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-json-view.