Git Product home page Git Product logo

Comments (7)

benbrignell avatar benbrignell commented on August 20, 2024

I can't seem to replicate this, can you provide any more info?

from styleguides.

bradfrost avatar bradfrost commented on August 20, 2024

I can't replicate either, but at the same time we should probably look into
some sort of lazy loading solution to prevent 50+ images from loading.

On Thursday, April 23, 2015, Ben Brignell [email protected] wrote:

I can't seem to replicate this, can you provide any more info?


Reply to this email directly or view it on GitHub
#127 (comment).


Brad Frost
http://bradfrost.com
http://twitter.com/brad_frost

from styleguides.

walkerde avatar walkerde commented on August 20, 2024

I go to sleep. I wake up. And now no issues. Can't replicate either. Odd. Wish I was more help.

First looked at it in Twitter's browser view off Brad's tweet. Crashed.

Sent to Pocket, tried to view there. Crashed.

Opened out in Safari. Crashed.

Copy pasted into Chrome. Crashed.

iPhone 6+ all apps and OS up to date.

from styleguides.

benbrignell avatar benbrignell commented on August 20, 2024

What twitter client are you using @walkerde? It's probably something to do with the amount of images - but I did quickly test and it seemed ok. I agree with @bradfrost we should have a more smarter way of loading them now there are a lot more.

Among others, I have tested this with a couple of very basic Android devices and it still loads fine for me, no memory/crashes from images, at least so far.

from styleguides.

benbrignell avatar benbrignell commented on August 20, 2024

Looked at it on a few more things now, still no issues. Images definitely would benefit from lazy loading. Perhaps @walkerde looking at the time of your tweet, maybe you happened to load it just as the build happened and had some caching problems weirdnessification.

from styleguides.

benbrignell avatar benbrignell commented on August 20, 2024

ok, I've thrown this around to a few people - nobody else has had it crash. So I suggest this get closed @bradfrost (I don't think I have perms to close the issue) - I will open an enhancement suggestion for lazy loading, and if @walkerde has it happen again we reopen with steps to replicate.

from styleguides.

bradfrost avatar bradfrost commented on August 20, 2024

Alright we'll close this out for now, but yep it's definitely a good idea to open an enhancement issue to smartly load images.

from styleguides.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.