Git Product home page Git Product logo

Comments (8)

maandree avatar maandree commented on May 18, 2024 2

See https://github.com/maandree/libkeccak/blob/master/Makefile#L7-L12

from libkeccak.

maandree avatar maandree commented on May 18, 2024 1

Should work with make install OSCONFIGFILE=macos.mk now.

from libkeccak.

wjmelements avatar wjmelements commented on May 18, 2024

The macOS equivalent of .so is .dylib iirc

from libkeccak.

wjmelements avatar wjmelements commented on May 18, 2024

How easy is it to create a condition so the makefile doesn't have to be modified?

from libkeccak.

maandree avatar maandree commented on May 18, 2024

It's very easy, but I want my Makefiles to be as portable as possible and POSIX make does not support such things.

from libkeccak.

cloudwizard avatar cloudwizard commented on May 18, 2024

It is fine to require modification but I suggest adding a line to the README. It would save a lot of searching. Thanks

from libkeccak.

zbeekman avatar zbeekman commented on May 18, 2024

A formula has been submitted to Mac Homebrew for libkeccak (with the eventual intention of including sha3sum, I believe). However, there is a problem with your macOS fix: it should be $(LIB_MAJOR).$(LIB_EXT) on macOS, e.g., libqhull.7.2.0.dylib not libqhull.dylib.7.2.0. I gather that POSIX makefiles do not have functions like GNU make does, so maybe there needs to be a variable to specify the SO name?

from libkeccak.

zbeekman avatar zbeekman commented on May 18, 2024

I can confirm that this compiles & installs correctly now. A PR for this was opened in Homebrew/homebrew-core: Homebrew/homebrew-core#36905

It needs a better test; the current test only includes a header and doesn't link anything. I may try to find time later (this weekend) to fix this up. If anyone wants to send me a patch, that would allow me to get to it sooner.

from libkeccak.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.