Comments (2)
Hey again, thanks for the suggestion!
I opted to do two things:
- Add the
/api/training-courses
endpoint in 2939b52. The data under it looks something like this:
[{
"number": "TC001",
"technique": "Tsunami",
"type": "Water",
"location": "Complete Gone with the Sillaro. Requires the Surfboard.",
"locationType": "quest"
},
{
"number": "TC002",
"technique": "Stone Wall",
"type": "Earth",
"location": "Windward Fort prison floor, cell in the water. Requires the Surfboard.",
"locationType": "found"
}]
- In fe63bb4 I made it so the
/api/temtems
endpoint can take aexpand
query parameter for a number of fields in the past, including techniques. Now, if you do/api/temtems?expand=techniques
, the API will fill out all the technique data, including adding training course information on atrainingCourse
key with an item in the same shape as what you'd get a list of from/api/training-courses
.
I decided to do it this way, as the dictionary approach, while good for looking up, isn't common convention for an API serving JSON, and makes it more difficult if for example someone wanted to just display a list of all available training courses. But by doing the endpoint as a list, and allowing it to be added by the API where most people would want it, hopefully it achieves what we want.
What do you think?
from temtem-api.
Looks good to me!
from temtem-api.
Related Issues (20)
- 'Conditions' endpoint retrieves wrong icon path for invogorated HOT 1
- Missing synergy effect data for priority improvements HOT 1
- Extend techniques from breeding with list of source temtem
- Multi-evolution Temtems like Tuwai or Venx are getting the wrong stage in the 'evolution' field HOT 2
- Saipark does not have the latest data HOT 2
- Extending data on the locations endpoint
- Lairs
- Chromeon techniques by levelling HOT 2
- Image Links not complete HOT 1
- Hatchmins has the incorrect value for evolutions
- All technique courses are 'TC001' in the /temtems route (whatever its called) HOT 1
- update freetem formula HOT 1
- Platypet evolutionary line is incorrect HOT 2
- Endpoint /api/techniques returns technique categories instead of individual techniques HOT 1
- the wikiUrl field in specific temtems Is the link to the old wiki HOT 1
- Temtem API call does not include Experience Yield Modifier
- Egg techniques are not listed by API
- Gear game description is empty, and effect is just "X is a gear" HOT 2
- Some links/images still reference the old wiki HOT 4
- Having expand=types on temtems call causes weaknesses to all be 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from temtem-api.